Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isConsoleRequest() may return erroneously when testing a Web application in Codeception #19101

Merged
merged 7 commits into from
Dec 21, 2021

Conversation

WinterSilence
Copy link
Contributor

@WinterSilence WinterSilence commented Dec 20, 2021

Fix web request running in console

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #19096

@samdark samdark changed the title Update TestCase.php Fix isConsoleRequest() may return erroneously when testing a Web application in Codeception Dec 20, 2021
@samdark
Copy link
Member

samdark commented Dec 21, 2021

@WinterSilence would you please add a line for CHANGELOG?

@samdark samdark added the type:bug Bug label Dec 21, 2021
@samdark samdark added this to the 2.0.44 milestone Dec 21, 2021
@samdark samdark added the status:ready for merge The pull request is OK to be merged. label Dec 21, 2021
@WinterSilence
Copy link
Contributor Author

@samdark done

@samdark samdark merged commit 8e0e5ad into yiisoft:master Dec 21, 2021
@samdark
Copy link
Member

samdark commented Dec 21, 2021

👍

@WinterSilence WinterSilence deleted the patch-3 branch June 1, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for merge The pull request is OK to be merged. type:bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants