Fix #20322: Correct escaping of hex ranges in Html::escapeJsRegularEx… #20330
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gularExpression
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20330 +/- ##
=========================================
Coverage 64.85% 64.85%
Complexity 11435 11435
=========================================
Files 431 431
Lines 37193 37193
=========================================
Hits 24120 24120
Misses 13073 13073 ☔ View full report in Codecov by Sentry. |
|
Thanks for pull request. Please add a line for CHANGELOG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20322
This PR corrects the escaping of hex ranges (\x00-\xFF) in Html::escapeJsRegularExpression, ensuring compatibility with JavaScript regular expressions.