Compat 2.4

.module.ini

@@ -0,0 +1,3 @@
+EXTENSION_VENDOR="Yireo"
+EXTENSION_NAME="CommonViewModels"
+COMPOSER_NAME="yireo/magento2-common-view-models"

CHANGELOG.md

@@ -0,0 +1,13 @@
+# Changelog
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
+
+## [0.0.2] - 29 July 2020
+### Added
+- Magento 2.4 compatibility
+
+## [0.0.1] - Undocumented

Test/Integration/ViewModel/CurrentProductTest.php

@@ -1,9 +1,11 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Yireo\CommonViewModels\Test\Integration;
 
 use Magento\Framework\App\RequestInterface;
+use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\HTTP\PhpEnvironment\Request;
 use Magento\Framework\ObjectManagerInterface;
 use Magento\TestFramework\Helper\Bootstrap;
@@ -18,28 +20,34 @@
  */
 class CurrentProductTest extends AbstractControllerTestCase
 {
+    /**
+     * @magentoDataFixture Magento/Catalog/_files/product_simple.php
+     * @throws NoSuchEntityException
+     */
     public function testIfCheckOfRightPageFails()
     {
         $this->expectException(\RuntimeException::class);
         $productId = 1;
 
+        /** @var CurrentProduct $viewModel */
         $viewModel = Bootstrap::getObjectManager()->get(CurrentProduct::class);
         $viewModel->initialize();
         $product = $viewModel->getProduct();
         $this->assertEquals($productId, $product->getId());
     }
 
+    /**
+     * @magentoDataFixture Magento/Catalog/_files/product_simple.php
+     * @throws NoSuchEntityException
+     */
     public function testIfTheRightPageWorks()
     {
         $productId = 1;
 
         /** @var Request $request */
-        //$request = Bootstrap::getObjectManager()->get(RequestInterface::class);
-        //$request->setActionName('view');
-        //$request->setControllerName('product');
-        //$request->setParams(['id' => $productId]);
-        $this->dispatch('catalog/product/view/id/'.$productId);
+        $this->dispatch('catalog/product/view/id/' . $productId);
 
+        /** @var CurrentProduct $viewModel */
         $viewModel = Bootstrap::getObjectManager()->get(CurrentProduct::class);
         $viewModel->initialize();
         $product = $viewModel->getProduct();

composer.json

@@ -1,7 +1,7 @@
 {
   "name": "yireo/magento2-common-view-models",
   "type": "magento2-module",
-  "version": "0.0.1",
+  "version": "0.0.2",
   "license": "OSL-3.0",
   "description": "",
   "keywords": [
@@ -15,9 +15,9 @@
     }
   ],
   "require": {
-    "magento/module-catalog": "^102.0|^103.0",
-    "magento/framework": "^102.0",
-    "php": ">=7.0.0"
+    "magento/module-catalog": "^102.0|^103.0|^104.0",
+    "magento/framework": "^102.0|^103.0",
+    "php": ">=7.2.0"
   },
   "require-dev": {
     "phpunit/phpunit": "*",
@@ -31,4 +31,4 @@
       "registration.php"
     ]
   }
-}
+}