Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update replace section for 2.4.5 #24

Closed
wants to merge 1 commit into from

Conversation

peterjaap
Copy link

A lot of bundled extensions have been removed by Magento

A lot of bundled extensions have been removed by Magento
@jissereitsma
Copy link
Collaborator

Actually, this will render the new releases incompatible with Magento 2.4.4 and older. I'd rather keep the wildcard in there. Also, the additional replace rules that are no longer needed for 2.4.5+ are not harming either (replacing something that is not there, still results in a non-existing package). What do you think?

@peterjaap
Copy link
Author

Aah right, that's how you approach this.

I was thinking about adding a tag per Magento version, but this would work too. Only problem with this is the current situation where there are hard-coded dependencies like yireo/magento2-replace-core#14 (comment).

If you would have a tag per Magento version, you could workaround this for a specific version.

@peterjaap peterjaap closed this Sep 24, 2022
@jissereitsma
Copy link
Collaborator

Yes and no. I've used separate branches per Magento version in the past, but this became a nightmare on its own to manage. Most problems arise not because of the composer replacements not working, but because of Magento code screwing up. But this is still nothing compared to the major issue of one replacement conflicting with another. As of yet, I'm more in favor of entirely new approach - to calculate the replacements based on some rules and then regenerate a new composer.json in the root alltogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants