Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid chars #55

Merged
merged 11 commits into from
Feb 7, 2022
Merged

Fix invalid chars #55

merged 11 commits into from
Feb 7, 2022

Conversation

yjmantilla
Copy link
Owner

@yjmantilla yjmantilla commented Feb 7, 2022

  • CNT implementation. Closes problem with using .cnt files  #48 , but by requiring the latest dev version of mne-bids. Once they include it on the stable version we should ask for the stable one.
  • Fixes bids_validator requirement missing in the user installation mode. This is used in heuristics.py.
  • Now if an entity value has '_' or '-', they will be changed to '' automatically to adapt to the bids standard. In the future it would be nice for the user to choose which replacement to do.
  • Now, files with problems for conversion or rules applying will be skipped and the corresponding error and filepath will be saved on the log.
  • Typo correction. Closes correct typo in documentation #53

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #55 (07d21ee) into main (ebf58a7) will decrease coverage by 0.30%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   83.01%   82.70%   -0.31%     
==========================================
  Files          15       15              
  Lines         736      746      +10     
==========================================
+ Hits          611      617       +6     
- Misses        125      129       +4     
Impacted Files Coverage Δ
sovabids/datasets.py 45.63% <0.00%> (ø)
sovabids/convert.py 93.47% <60.00%> (-4.20%) ⬇️
sovabids/rules.py 89.16% <66.66%> (-0.71%) ⬇️
sovabids/parsers.py 92.00% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebf58a7...07d21ee. Read the comment docs.

@yjmantilla yjmantilla merged commit 33d03eb into main Feb 7, 2022
@yjmantilla yjmantilla deleted the fix-invalid-chars branch February 7, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

correct typo in documentation problem with using .cnt files
1 participant