Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of elements #37

Closed
ndelangen opened this issue Sep 13, 2018 · 2 comments · Fixed by #41
Closed

Order of elements #37

ndelangen opened this issue Sep 13, 2018 · 2 comments · Fixed by #41
Assignees
@ndelangen
Labels
enhancement

Comments

@ndelangen
Copy link
Contributor

For usability and accessibility it would be better to place the popup content AFTER the trigger.

This will allow TAB-index to work as expected.

As a work-around I have added tabIndex="1" to the trigger and set keepTooltipInside to true.
@yjose
Copy link
Owner

yjose commented Sep 13, 2018

Hi @ndelangen, happy to see you here!
Thank you for your remarks, if you can open a pull request with your suggestion it would be very helpful.

@ndelangen
Copy link
Contributor Author

Sure, will do.

ndelangen added a commit to ndelangen/reactjs-popup that referenced this issue Sep 22, 2018
@ndelangen
FIX yjose#37
25af5f1
@ndelangen ndelangen mentioned this issue Sep 22, 2018
Merged
@yjose yjose closed this as completed in #41 Sep 29, 2018
yjose added a commit that referenced this issue Sep 29, 2018
@yjose
Merge pull request #41 from ndelangen/fix/37
3afd7a5 
FIX #37
web3gru pushed a commit to web3gru/reactjs-popup that referenced this issue May 13, 2023
FIX yjose/reactjs-popup#37
6968380
web3gru pushed a commit to web3gru/reactjs-popup that referenced this issue May 13, 2023
Merge pull request #41 from ndelangen/fix/37
f5375d6 
FIX yjose/reactjs-popup#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndelangen ndelangen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX https://github.com/yjose/reactjs-popup/issues/37 ndelangen/reactjs-popup
2 participants
@ndelangen @yjose