Clean up yDoc observers on PM plugin destroy

yjs · Apr 14, 2021 · 90ddee1 · 90ddee1
1 parent 8cd9639
commit 90ddee1
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/src/plugins/sync-plugin.js b/src/plugins/sync-plugin.js
@@ -202,14 +202,17 @@ export class ProsemirrorBinding {
      * current selection as relative positions in the Yjs model
      */
     this.beforeTransactionSelection = null
-    this.doc.on('beforeAllTransactions', () => {
+    this.beforeAllTransactions = () => {
       if (this.beforeTransactionSelection === null) {
         this.beforeTransactionSelection = getRelativeSelection(this, prosemirrorView.state)
       }
-    })
-    this.doc.on('afterAllTransactions', e => {
+    }
+    this.afterAllTransactions = () => {
       this.beforeTransactionSelection = null
-    })
+    }
+
+    this.doc.on('beforeAllTransactions', this.beforeAllTransactions)
+    this.doc.on('afterAllTransactions', this.afterAllTransactions)
     yXmlFragment.observeDeep(this._observeFunction)
 
     this._domSelectionInView = null
@@ -370,6 +373,8 @@ export class ProsemirrorBinding {
 
   destroy () {
     this.type.unobserveDeep(this._observeFunction)
+    this.doc.off('beforeAllTransactions', this.beforeAllTransactions)
+    this.doc.off('afterAllTransactions', this.afterAllTransactions)
   }
 }