[Example Test Case] - Some text is duplicated when two users concurrently make changes at the beginning of the same line #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacroMackie
changed the title
MacroMackie
force-pushed
the
macromackie/collab-editing-bug-newlines
branch
from
aedd3ba to
9e797f7
Compare
MacroMackie
commented
Jul 17, 2024
Comment on lines
+602
to
+606
| const initialContent = schema.node('doc', null, [ | ||
| schema.node('paragraph', null, [schema.text('123')]), | ||
| schema.node('paragraph'), | ||
| schema.node('paragraph', null, [schema.text('456')]) | ||
| ]) |
There was a problem hiding this comment.
Example doc with a newline in the middle
MacroMackie
commented
Jul 17, 2024
Comment on lines
+621
to
+622
| const insertA = view1.state.tr.insertText('A', 6) | ||
| const insertX = view2.state.tr.insertText('X', 6) |
There was a problem hiding this comment.
I insert A and X
(Attempting to simulate two different editors)
MacroMackie
commented
Jul 17, 2024
Comment on lines
+646
to
+649
| t.assert( | ||
| contentAfterFirstInsert === '<paragraph>123</paragraph><paragraph>AX</paragraph><paragraph>456</paragraph>' || | ||
| contentAfterFirstInsert === '<paragraph>123</paragraph><paragraph>XA</paragraph><paragraph>456</paragraph>' | ||
| ) |
There was a problem hiding this comment.
Things look good at this point
(The test doesn't have a preference for which order wins the tiebreak)
MacroMackie
commented
Jul 17, 2024
Comment on lines
+652
to
+653
| const insertB = view1.state.tr.insertText('B', 7) | ||
| const insertY = view2.state.tr.insertText('Y', 7) |
There was a problem hiding this comment.
Another round of edits (using position 7, although there is probably a better way to do this (somewhat dependant on the earlier tiebreak?)
MacroMackie
commented
Jul 17, 2024
Comment on lines
+677
to
+684
| // TODO: This is failing. | ||
| // contentAfterSecondInsert == <paragraph>123</paragraph><paragraph>ABXYX</paragraph><paragraph>456</paragraph> | ||
| // Note the duplication of `X`. | ||
|
|
||
| t.assert( | ||
| contentAfterSecondInsert === '<paragraph>123</paragraph><paragraph>ABXY</paragraph><paragraph>456</paragraph>' || | ||
| contentAfterSecondInsert === '<paragraph>123</paragraph><paragraph>XYAB</paragraph><paragraph>456</paragraph>' | ||
| ) |
There was a problem hiding this comment.
Duplicate X character (this test is failing)
MacroMackie
changed the title
2 tasks
MacroMackie
changed the title
|
Thank you, this PR was immensely helpful!! I fixed the issue and added a test case for it (based on your work). |
nperez0111
pushed a commit
to Pruxis/y-prosemirror
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the issue described here:
I've attempted to create a test case which reproduces the described issue.
CleanShot.2024-07-17.at.12.59.19.mp4
( Note that I'm not too familiar with the y.js internals, so the test may not be perfectly representative )