New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid throwing an exception if the current selection no longer makes sense when initializing ySyncPlugin #171

Merged

dmonad merged 1 commit into yjs:master from gvergnaud:fix-runtime-error-when-adding-y-sync-plugin

Nov 22, 2024

+9 −1

Contributor

gvergnaud commented Nov 21, 2024 •

edited

Loading

Fixes #170.


          fix: avoid throwing an exception if the current selection no longer m…

a501e0b

…akes sense when initializing ySyncPlugin

Member

dmonad commented Nov 22, 2024

Awesome PR!

Precise bug report
Reproducible code
Working fix that even uses lib0.math instead of Math.

It took me just a few minutes and saved me a lot of time. Thanks!!

Will merge, and release now. There should be a new release with a fix in a few minutes.

dmonad merged commit 0eef55a into yjs:master

YousefED mentioned this pull request

Document sometimes freezes when sync editing numerique-gouv/impress#440

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet