fix: abort scheduled processes on destruction #71

hoebbelsB · 2021-10-16T21:30:08Z

fixes #70

This reverts commit 0039353.

ValentaTomas · 2021-12-14T13:14:06Z

This fix (cursor-plugin.js part specifically) solved my problem with #70 too - it is an almost constant problem when you allow user to switch between several ProseMirror editors.

Are there some other problems with this PR request that prevents it from being merged?

ValentaTomas · 2021-12-17T18:39:53Z

Shouldn't we also clear setTimeout from

y-prosemirror/src/plugins/sync-plugin.js

Line 114 in f593d68

setTimeout(() => {

?

Also how about using timeout from lib0/eventloop-- the timeout is already used in this package when updating cursor.

I would gladly make the changes, but I don't want to create a new PR that is essentially the same as this one.

@dmonad Can you please check this issue? I'm using these fixed in our project, but I would be really glad if I could use the y-prosemirror official package again.

@hoebbelsB

parent 984175f author Dov Alperin <dzalperin@gmail.com> 1635443219 -0400 committer Dov Alperin <dzalperin@gmail.com> 1640994693 -0500 Make y-prosemirror behave with subdocuments + throw some safety checks in to avoid common (in my testing) footguns Check for object nullness in equalAttrs As typeof null is object, equalAttrs falsely expects it to produce Object.keys thus crashing when comparing object against a null value. update lib0 1.0.11 (upstream) Linking to documentation for Awareness protocol. Some refactors Bump with bugfix Bump again Adopt yjs#71 h/t @hoebbelsB Revert "Adopt yjs#71 h/t @hoebbelsB" This reverts commit 0039353. Use our own protocols Who needs safety checks anyway? Revert some debugging changes in search of a known good state Experimental fix for the cursor jumping bug More hacks for subdocument bs revert parent 984175f author Dov Alperin <dzalperin@gmail.com> 1635443219 -0400 committer Dov Alperin <dzalperin@gmail.com> 1640994693 -0500 Make y-prosemirror behave with subdocuments + throw some safety checks in to avoid common (in my testing) footguns Check for object nullness in equalAttrs As typeof null is object, equalAttrs falsely expects it to produce Object.keys thus crashing when comparing object against a null value. update lib0 1.0.11 (upstream) Linking to documentation for Awareness protocol. Some refactors Bump with bugfix Bump again Adopt yjs#71 h/t @hoebbelsB Revert "Adopt yjs#71 h/t @hoebbelsB" This reverts commit 0039353. Use our own protocols Who needs safety checks anyway? Revert some debugging changes in search of a known good state Experimental fix for the cursor jumping bug More hacks for subdocument bs revert can pass undoManager to undo-plugin can pass undoManager to undo-plugin can pass undoManager to undo-plugin can pass undoManager to undo-plugin remove yarn.lock 1.0.14 Bump Respect stateField key everywhere actually Fix some places that ignored the statekey

@hoebbelsB

parent 984175f author Dov Alperin <dzalperin@gmail.com> 1635443219 -0400 committer Dov Alperin <dzalperin@gmail.com> 1640994693 -0500 Make y-prosemirror behave with subdocuments + throw some safety checks in to avoid common (in my testing) footguns Check for object nullness in equalAttrs As typeof null is object, equalAttrs falsely expects it to produce Object.keys thus crashing when comparing object against a null value. update lib0 1.0.11 (upstream) Linking to documentation for Awareness protocol. Some refactors Bump with bugfix Bump again Adopt yjs#71 h/t @hoebbelsB Revert "Adopt yjs#71 h/t @hoebbelsB" This reverts commit 0039353. Use our own protocols Who needs safety checks anyway? Revert some debugging changes in search of a known good state Experimental fix for the cursor jumping bug More hacks for subdocument bs revert parent 984175f author Dov Alperin <dzalperin@gmail.com> 1635443219 -0400 committer Dov Alperin <dzalperin@gmail.com> 1640994693 -0500 Make y-prosemirror behave with subdocuments + throw some safety checks in to avoid common (in my testing) footguns Check for object nullness in equalAttrs As typeof null is object, equalAttrs falsely expects it to produce Object.keys thus crashing when comparing object against a null value. update lib0 1.0.11 (upstream) Linking to documentation for Awareness protocol. Some refactors Bump with bugfix Bump again Adopt yjs#71 h/t @hoebbelsB Revert "Adopt yjs#71 h/t @hoebbelsB" This reverts commit 0039353. Use our own protocols Who needs safety checks anyway? Revert some debugging changes in search of a known good state Experimental fix for the cursor jumping bug More hacks for subdocument bs revert can pass undoManager to undo-plugin can pass undoManager to undo-plugin can pass undoManager to undo-plugin can pass undoManager to undo-plugin remove yarn.lock 1.0.14 Bump Respect stateField key everywhere actually Fix some places that ignored the statekey

tommoor · 2022-02-28T04:26:54Z

This seems like a clean bugfix~ not sure why it's sat for months.

dmonad · 2022-03-29T11:43:35Z

Thank you for the PR @hoebbelsB and sorry that it took so long.

I went for a different approach that checks whether the binding is destroyed. I prefer not to clear timeouts because that leads to further issues in the future. setMeta, for example is used in third-party packages as well that don't know that they should clear the timeout.

@ValentaTomas I implemented your suggestion as well and switched from setTimeout to eventloop.timeout. Thanks for the suggestion

ValentaTomas · 2022-04-05T00:23:05Z

Thank you for your work!

hoebbelsB added 2 commits October 16, 2021 23:29

fix: abort scheduled processes on destruction

92b6de3

chore: run standard --fix

f593d68

DAlperin added a commit to DAlperin/y-prosemirror that referenced this pull request Dec 9, 2021

Adopt yjs#71 h/t @hoebbelsB

0039353

DAlperin added a commit to DAlperin/y-prosemirror that referenced this pull request Dec 9, 2021

Revert "Adopt yjs#71 h/t @hoebbelsB"

511d0b4

This reverts commit 0039353.

hoebbelsB mentioned this pull request Feb 15, 2022

Clear timeout when destroying plugin #92

Merged

dmonad closed this in 6a1433a Mar 29, 2022

geekuillaume pushed a commit to geekuillaume/y-prosemirror that referenced this pull request Apr 14, 2022

handle setTimeout edge-case. closes yjs#71 closes yjs#70

682ee0f

ronnyroeller pushed a commit to Collaborne/y-prosemirror that referenced this pull request May 11, 2022

handle setTimeout edge-case. closes yjs#71 closes yjs#70

cb70a2a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: abort scheduled processes on destruction #71

fix: abort scheduled processes on destruction #71

hoebbelsB commented Oct 16, 2021

ValentaTomas commented Dec 14, 2021 •

edited

Loading

ValentaTomas commented Dec 17, 2021 •

edited

Loading

tommoor commented Feb 28, 2022

dmonad commented Mar 29, 2022

ValentaTomas commented Apr 5, 2022

fix: abort scheduled processes on destruction #71

fix: abort scheduled processes on destruction #71

Conversation

hoebbelsB commented Oct 16, 2021

ValentaTomas commented Dec 14, 2021 • edited Loading

ValentaTomas commented Dec 17, 2021 • edited Loading

tommoor commented Feb 28, 2022

dmonad commented Mar 29, 2022

ValentaTomas commented Apr 5, 2022

ValentaTomas commented Dec 14, 2021 •

edited

Loading

ValentaTomas commented Dec 17, 2021 •

edited

Loading