Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect generated type of WebrtcProvider constructor #38

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

exuanbo
Copy link
Contributor

@exuanbo exuanbo commented Jul 14, 2022

Fixes: #29

Before:

Screen Shot 2022-07-14 at 8 19 58 PM

After:

Screen Shot 2022-07-14 at 8 21 31 PM

@douira
Copy link

douira commented Oct 21, 2022

I've also noticed this issue. Since I can't see how this would be a breaking change (since the type is being loosened) I would appreciate if this could be merged.

@djmaze
Copy link

djmaze commented Jan 8, 2023

Also experiencing this problem. Please merge this.

@dmonad
Copy link
Member

dmonad commented Jan 16, 2023

Thanks for the PR & sorry for the delay. I'll publish a new release shortly..

@dmonad dmonad merged commit 4685d36 into yjs:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Over-strict type declaration for the options of WebRtcProvider
4 participants