Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package): missing "type" property in export #50

Merged
merged 1 commit into from
Jun 16, 2023
Merged

fix(package): missing "type" property in export #50

merged 1 commit into from
Jun 16, 2023

Conversation

AkaraChen
Copy link
Contributor

@AkaraChen AkaraChen commented May 25, 2023 •
edited
Loading

Can't get type in TypeScript 5.0.4

error

This PR add the missing types property to suppress this error.

After:
image

Same issues in y-websocket: yjs/y-websocket#138

@dmonad dmonad merged commit 661a9e2 into yjs:master Jun 16, 2023
@dmonad
Copy link
Member

dmonad commented Jun 16, 2023

Thanks!

@sdevil7th
Copy link

Hi @dmonad !
I've recently started working with yjs and y-webrtc and I admit it's amazing! Great job!
I'm facing this issue which is blocking my build, I've found some workarounds but they are a bit hacky. Could you please let me know when this fix is coming out? It'd be really helpful.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AkaraChen @dmonad @sdevil7th