Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percolate dladdr() errors upwards. #1517

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

ltratt
Copy link
Contributor

@ltratt ltratt commented Dec 16, 2024

The fundamental change here is to turn an unwrap in vaddr_to_off into an Err but this part of hwtracer is somewhat messy, so a seemingly simple change (unwrap -> Err(...)) requires lots of boilerplate.

The fundamental change here is to turn an `unwrap` in `vaddr_to_off`
into an `Err` but this part of hwtracer is somewhat messy, so a
seemingly simple change (`unwrap` -> `Err(...)`) requires lots of
boilerplate.
@vext01
Copy link
Contributor

vext01 commented Dec 16, 2024

Yikes! Thanks for this. At least we will get a descriptive error message.

@vext01 vext01 added this pull request to the merge queue Dec 16, 2024
Merged via the queue into ykjit:master with commit 23505ef Dec 16, 2024
2 checks passed
@ltratt ltratt deleted the percolate_vaddr_error branch December 20, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants