Saving manuscript count (#4425)

* Saving manuscript count * linting * add test * simplify code
yldio · Oct 22, 2024 · 8d26292 · 8d26292
1 parent 5b7050e
commit 8d26292
Show file tree

Hide file tree

Showing 9 changed files with 287 additions and 9 deletions.
diff --git a/apps/crn-server/src/data-providers/contentful/manuscript.data-provider.ts b/apps/crn-server/src/data-providers/contentful/manuscript.data-provider.ts
@@ -3,6 +3,8 @@ import {
   Environment,
   FetchManuscriptByIdQuery,
   FetchManuscriptByIdQueryVariables,
+  FetchManuscriptsByTeamIdQuery,
+  FETCH_MANUSCRIPTS_BY_TEAM_ID,
   FETCH_MANUSCRIPT_BY_ID,
   getLinkAsset,
   getLinkAssets,
@@ -46,6 +48,19 @@ export class ManuscriptContentfulDataProvider
     throw new Error('Method not implemented.');
   }
 
+  async fetchCountByTeamId(id: string) {
+    const { teams } = await this.contentfulClient.request<
+      FetchManuscriptsByTeamIdQuery,
+      FetchManuscriptByIdQueryVariables
+    >(FETCH_MANUSCRIPTS_BY_TEAM_ID, { id });
+
+    return (
+      teams?.linkedFrom?.manuscriptsCollection?.items.filter(
+        (item) => item?.teamsCollection?.items[0]?.sys.id === id,
+      ).length || 0
+    );
+  }
+
   async fetchById(id: string): Promise<ManuscriptDataObject | null> {
     const { manuscripts } = await this.contentfulClient.request<
       FetchManuscriptByIdQuery,
@@ -95,6 +110,7 @@ export class ManuscriptContentfulDataProvider
       {
         fields: addLocaleToFields({
           ...version,
+          count: 1,
           teams: getLinkEntities(version.teams),
           firstAuthors: getLinkEntities(version.firstAuthors),
           correspondingAuthor: getLinkEntities(version.correspondingAuthor),
@@ -120,9 +136,12 @@ export class ManuscriptContentfulDataProvider
 
     const { id: manuscriptVersionId } = manuscriptVersionEntry.sys;
 
+    const currentCount = (await this.fetchCountByTeamId(teamId)) || 0;
+
     const manuscriptEntry = await environment.createEntry('manuscripts', {
       fields: addLocaleToFields({
         ...plainFields,
+        count: currentCount + 1,
         teams: getLinkEntities([teamId]),
         versions: getLinkEntities([manuscriptVersionId]),
       }),
@@ -138,6 +157,7 @@ const parseGraphQLManuscript = (
   manuscripts: ManuscriptItem,
 ): ManuscriptDataObject => ({
   id: manuscripts.sys.id,
+  count: manuscripts.count || 0,
   title: manuscripts.title || '',
   teamId: manuscripts.teamsCollection?.items[0]?.sys.id || '',
   status: manuscriptMapStatus(manuscripts.status) || undefined,

diff --git a/apps/crn-server/test/data-providers/contentful/manuscript.data-provider.test.ts b/apps/crn-server/test/data-providers/contentful/manuscript.data-provider.test.ts
@@ -15,7 +15,10 @@ import {
   getManuscriptCreateDataObject,
   getManuscriptDataObject,
 } from '../../fixtures/manuscript.fixtures';
-import { getUsersTeamsCollection } from '../../fixtures/teams.fixtures';
+import {
+  getContentfulGraphql,
+  getUsersTeamsCollection,
+} from '../../fixtures/teams.fixtures';
 import { getContentfulGraphqlClientMock } from '../../mocks/contentful-graphql-client.mock';
 import { getContentfulEnvironmentMock } from '../../mocks/contentful-rest-client.mock';
 
@@ -32,6 +35,7 @@ describe('Manuscripts Contentful Data Provider', () => {
 
   const contentfulGraphqlClientMockServer =
     getContentfulGraphqlClientMockServer({
+      ...getContentfulGraphql(),
       UsersTeamsCollection: () => getUsersTeamsCollection(),
       Manuscripts: () => getContentfulGraphqlManuscript(),
       ManuscriptsVersionsCollection: () =>
@@ -60,6 +64,22 @@ describe('Manuscripts Contentful Data Provider', () => {
     });
   });
 
+  describe('FetchCountByTeamId', () => {
+    it('Should return 0 when team does not exist', async () => {
+      const teamId = 'team-id-2';
+      const result =
+        await manuscriptDataProviderMockGraphql.fetchCountByTeamId(teamId);
+      expect(result).toBe(0);
+    });
+
+    it('Should fetch the count of existing manuscripts for a given team', async () => {
+      const teamId = 'team-id-1';
+      const result =
+        await manuscriptDataProviderMockGraphql.fetchCountByTeamId(teamId);
+      expect(result).toBe(0);
+    });
+  });
+
   describe('Fetch-by-id', () => {
     test('Should fetch the manuscript from Contentful GraphQl', async () => {
       const manuscriptId = 'manuscript-id-1';
@@ -148,6 +168,7 @@ describe('Manuscripts Contentful Data Provider', () => {
       const result = await manuscriptDataProvider.fetchById('1');
       expect(result).toEqual({
         id: 'manuscript-id-1',
+        count: 1,
         teamId: '',
         title: '',
         versions: [],
@@ -237,7 +258,7 @@ describe('Manuscripts Contentful Data Provider', () => {
         .calledWith(manuscriptCreateDataObject.versions[0]!.manuscriptFile.id)
         .mockResolvedValue(assetMock);
 
-      const result = await manuscriptDataProvider.create({
+      const result = await manuscriptDataProviderMockGraphql.create({
         ...manuscriptCreateDataObject,
         userId: 'user-id-0',
       });
@@ -284,6 +305,7 @@ describe('Manuscripts Contentful Data Provider', () => {
             },
             submissionDate: { 'en-US': undefined },
             correspondingAuthor: { 'en-US': [] },
+            count: { 'en-US': 1 },
             additionalAuthors: { 'en-US': [] },
             teams: {
               'en-US': [
@@ -328,6 +350,9 @@ describe('Manuscripts Contentful Data Provider', () => {
           eligibilityReasons: {
             'en-US': [],
           },
+          count: {
+            'en-US': 3,
+          },
           versions: {
             'en-US': [
               {
@@ -384,7 +409,7 @@ describe('Manuscripts Contentful Data Provider', () => {
         )
         .mockResolvedValue(assetMock);
 
-      const result = await manuscriptDataProvider.create({
+      const result = await manuscriptDataProviderMockGraphql.create({
         ...manuscriptCreateDataObject,
         userId: 'user-id-0',
       });
@@ -445,6 +470,7 @@ describe('Manuscripts Contentful Data Provider', () => {
             },
             submissionDate: { 'en-US': undefined },
             correspondingAuthor: { 'en-US': [] },
+            count: { 'en-US': 1 },
             additionalAuthors: { 'en-US': [] },
             teams: {
               'en-US': [
@@ -475,6 +501,9 @@ describe('Manuscripts Contentful Data Provider', () => {
           title: {
             'en-US': 'Manuscript Title',
           },
+          count: {
+            'en-US': 3,
+          },
           teams: {
             'en-US': [
               {

diff --git a/apps/crn-server/test/fixtures/manuscript.fixtures.ts b/apps/crn-server/test/fixtures/manuscript.fixtures.ts
@@ -15,6 +15,7 @@ export const getManuscriptDataObject = (
   id: 'manuscript-id-1',
   title: 'Manuscript Title',
   teamId: 'team-1',
+  count: 1,
   versions: [
     {
       id: 'version-1',
@@ -62,6 +63,7 @@ export const getContentfulGraphqlManuscript = (
     id: 'manuscript-id-1',
   },
   title: 'Manuscript Title',
+  count: 1,
   teamsCollection: {
     items: [{ sys: { id: 'team-1' } }],
   },