build(ts): require project references to all dependencies #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeysal
force-pushed
the
ts-project-references
branch
2 times, most recently
from
f10349b to
2805aab
Compare
jeysal
force-pushed
the
ts-project-references
branch
from
2805aab to
3f5c306
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out not specifying them is not an option, even when we include all projects in the build anyway. They are still required for TypeScript to understand the dependency graph and build in the correct order. This was surfaced by #22.
So we do have to specify them all, but I extended our script to automatically check and enforce that they are present.