Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASAP-290 Fix prettier version #4116

Closed
wants to merge 9 commits into from

Conversation

gabiayako
Copy link
Collaborator

Updating prettier version to 3.0.3 so it uses the fix below introduced in this release https://github.com/prettier/prettier/blob/main/CHANGELOG.md#303

Prettier v3 uses dynamic imports, user yarnpkg/berry#5411 (comment) when Yarn's PnP mode is enabled, add preferUnplugged: true to package.json, so Yarn will install Prettier as unplug by default.

Also @typescript-eslint/eslint-plugin and @typescript-eslint/parser were updated accordingly to this PR https://github.com/yldio/asap-hub/pull/4047/files


Note: It's necessary to reload window after changing to this branch to see it working as the video below

Screen.Recording.2024-01-10.at.10.23.48.mov

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40acc50) 99.41% compared to head (0532bae) 99.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4116   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files         944      944           
  Lines       16541    16541           
  Branches     5108     5108           
=======================================
  Hits        16444    16444           
  Misses         97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabiayako gabiayako force-pushed the ASAP-290-fix-prettier-support-in-ide branch from 37d34c1 to 60ee0b5 Compare January 10, 2024 13:54
This reverts commit 57d8c92.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant