-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASAP-290 Fix prettier version #4116
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4116 +/- ##
=======================================
Coverage 99.41% 99.41%
=======================================
Files 944 944
Lines 16541 16541
Branches 5108 5108
=======================================
Hits 16444 16444
Misses 97 97 ☔ View full report in Codecov by Sentry. |
37d34c1
to
60ee0b5
Compare
60ee0b5
to
2b3392a
Compare
This reverts commit 57d8c92.
This reverts commit 08a4b71.
9332ff9
to
a9f713b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating prettier version to
3.0.3
so it uses the fix below introduced in this release https://github.com/prettier/prettier/blob/main/CHANGELOG.md#303Also
@typescript-eslint/eslint-plugin
and@typescript-eslint/parser
were updated accordingly to this PR https://github.com/yldio/asap-hub/pull/4047/filesNote: It's necessary to reload window after changing to this branch to see it working as the video below
Screen.Recording.2024-01-10.at.10.23.48.mov