Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ASAP-415 Add Working-Group Public API endpoint #4266

Merged

Conversation

peterstarling
Copy link
Contributor

@peterstarling peterstarling commented May 8, 2024

  • add new public endpoints
  • add publish date and version to the responses

Notes

  • we dont need pagination here really as the amount of working groups is so insignificant it was never implemented in our endpoints either - I think we can send it to GMMB as is but let me know what you think

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (8636694) to head (2109a8d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4266   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files         998      999    +1     
  Lines       18163    18183   +20     
  Branches     5671     5674    +3     
=======================================
+ Hits        18061    18081   +20     
  Misses        102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

): gp2Model.PublicWorkingGroupResponse => ({
id: workingGroup.id,
description: workingGroup.description,
members: workingGroup.members,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I think we need more data on members, don't we?

It's listed in ticket

  • degree
  • role
  • dept
  • institution
  • city
  • country

and in the website (https://gp2.org/working-group-directory/) passed as reference we have

Screenshot 2024-05-09 at 07 18 43

so these info seems to be used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per our discussion - we decided to leave these out and GMMB don't seem to need any extra information embedded for the nested resources

@peterstarling peterstarling merged commit d8c3ee8 into master May 9, 2024
63 checks passed
@peterstarling peterstarling deleted the feature/ASAP-415-add-working-group-public-api-endpoint branch May 9, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants