-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ASAP-415 Add Working-Group Public API endpoint #4266
feat: ASAP-415 Add Working-Group Public API endpoint #4266
Conversation
42bba76
to
2109a8d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4266 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 998 999 +1
Lines 18163 18183 +20
Branches 5671 5674 +3
=======================================
+ Hits 18061 18081 +20
Misses 102 102 ☔ View full report in Codecov by Sentry. |
): gp2Model.PublicWorkingGroupResponse => ({ | ||
id: workingGroup.id, | ||
description: workingGroup.description, | ||
members: workingGroup.members, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I think we need more data on members, don't we?
It's listed in ticket
- degree
- role
- dept
- institution
- city
- country
and in the website (https://gp2.org/working-group-directory/) passed as reference we have
so these info seems to be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per our discussion - we decided to leave these out and GMMB don't seem to need any extra information embedded for the nested resources
Notes