-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Engagement analytics logic #4426
Conversation
lctrt
commented
Oct 24, 2024
- update engagement % counting to use members instead of total speakers
- engagement performance uses percentage data
- update engagement table to use % for performance comparison
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4426 +/- ##
==========================================
- Coverage 99.46% 99.45% -0.01%
==========================================
Files 1066 1066
Lines 20690 20712 +22
Branches 6502 6508 +6
==========================================
+ Hits 20580 20600 +20
- Misses 110 112 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it's not written down in the ticket I remember we discussed about making some adjustments to the Caption
We could take a look with Padmini how it should change though, but I think at least we agreed at the time that we would have %
in the Unique Speakers All Roles
and Unique Speakers: Key Personnel