Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Engagement analytics logic #4426

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Update Engagement analytics logic #4426

merged 5 commits into from
Oct 24, 2024

Conversation

lctrt
Copy link
Collaborator

@lctrt lctrt commented Oct 24, 2024

  • update engagement % counting to use members instead of total speakers
  • engagement performance uses percentage data
  • update engagement table to use % for performance comparison

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (8d26292) to head (22a879a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4426      +/-   ##
==========================================
- Coverage   99.46%   99.45%   -0.01%     
==========================================
  Files        1066     1066              
  Lines       20690    20712      +22     
  Branches     6502     6508       +6     
==========================================
+ Hits        20580    20600      +20     
- Misses        110      112       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gabiayako gabiayako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it's not written down in the ticket I remember we discussed about making some adjustments to the Caption

We could take a look with Padmini how it should change though, but I think at least we agreed at the time that we would have % in the Unique Speakers All Roles and Unique Speakers: Key Personnel

@lctrt lctrt merged commit d7c4b09 into master Oct 24, 2024
62 of 63 checks passed
@lctrt lctrt deleted the ASAP-731 branch October 24, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants