You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
** Is your feature request related to a problem? Please describe. ** Originally posted by @BigRoy in #4552 (comment)
Issue with root replacement for config tempate
What if the root is /mnt/P and the path had /mnt/P/projects/mnt/P/files? This should only replace the actual exact beginning? What if the root was just /projects or /share - no idea what someone comes up with on unix.
Also, what's ensuring the path dividers / or \ are the same - and path case sensitivity on some platforms?
I feel like we might need a dedicated safer method here?
What's the reason it should only ever allow replacement of the work root?
Also, another question - why are we formatting the additional data here like this instead of the way the colorspace config data actually gets applied too?
colorspaceTemplate only exists in this code - why not directly acquire the data in the way we're setting them?
Issue with colorspace workflow in job submitter itself
Since the sollution was developed at the moment when colorspace data setter abstraction were not finalized to all requirements needed for Maya ACES worlfow, the worklfow should be improved.
Actual code is collecting data into additional_data as required keys in instance.data and then those data are used as required keys in representation data assebly function. At the time of this issue was created, #4556 was in the review and it is introducing colorspace workfow as mixin parent class so we can enhance the submitter plugin with it and use its functionality for the purpose of representation infusion with colorspace data.
Another point is if we should be storing Display and View at instance data or rather in context data. I believe it should be instance level so we avoid an issues at editorial publishing. But config data should be stored at context data for sure.
** Is your feature request related to a problem? Please describe. **
Originally posted by @BigRoy in #4552 (comment)
Issue with root replacement for config tempate
What if the root is
/mnt/P
and the path had/mnt/P/projects/mnt/P/files
? This should only replace the actual exact beginning? What if the root was just/projects
or/share
- no idea what someone comes up with on unix.Also, what's ensuring the path dividers
/
or\
are the same - and path case sensitivity on some platforms?I feel like we might need a dedicated safer method here?
Should this instead be using
anatomy.find_root_template_from_path
?What's the reason it should only ever allow replacement of the work root?
Also, another question - why are we formatting the additional data here like this instead of the way the colorspace config data actually gets applied too?
colorspaceTemplate
only exists in this code - why not directly acquire the data in the way we're setting them?Issue with colorspace workflow in job submitter itself
Since the sollution was developed at the moment when colorspace data setter abstraction were not finalized to all requirements needed for Maya ACES worlfow, the worklfow should be improved.
Actual code is collecting data into
additional_data
as required keys in instance.data and then those data are used as required keys in representation data assebly function. At the time of this issue was created, #4556 was in the review and it is introducing colorspace workfow as mixin parent class so we can enhance the submitter plugin with it and use its functionality for the purpose of representation infusion with colorspace data.Another point is if we should be storing Display and View at instance data or rather in context data. I believe it should be instance level so we avoid an issues at editorial publishing. But config data should be stored at context data for sure.
[cuID:OP-5159]
The text was updated successfully, but these errors were encountered: