Maya: OP-2630 acescg maya

[tokejepsen]

Brief description

Resolves #2712

Additional info

This grabs OCIO colour data and injects as colorspaceData to transcode between colourspaces.

This builds on #4195 and #4291

Testing Steps

1. Setup recommended output profile project_settings/global/publish/ExtractOIIOTranscode/profiles
   
2. Setup render in Maya.
3. Publish to Deadline.

[jakubjezek001]

Task linked: OP-2630 Quick way to produce reviews from ACEScg Maya renders

[hound]

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/usr/local/bin/flake8", line 8, in 
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
    self.visit(item)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 381, in generic_visit
    self.visit(value)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

[BigRoy]

Is this PR to the wrong branch? There's a huge list of changes. :)

[tokejepsen]

Is this PR to the wrong branch? There's a huge list of changes. :)

Its build on #4195 and #4291, which are not merged into develop yet.

[BigRoy]

Ok thanks - it's good to note that those also don't seem to be merging into develop but into the 3.15.x branch.

[antirotor]

Looks great. Just one question - if we are adding colorspace information to instances (per AOV in Maya), how do we handle cases where color information is not needed or is not even desired. Like data type AOVs - point positions, normals etc. we don't want any conversions on them, yet if I am not mistaken, they'll inherit colorspace from the context? We don't produce reviewable from them, but thumbnails yes - if the file has data in rgba channels.

[tokejepsen]

Looks great. Just one question - if we are adding colorspace information to instances (per AOV in Maya), how do we handle cases where color information is not needed or is not even desired. Like data type AOVs - point positions, normals etc. we don't want any conversions on them, yet if I am not mistaken, they'll inherit colorspace from the context? We don't produce reviewable from them, but thumbnails yes - if the file has data in rgba channels.

Good point. I'll test a workflow for this, but think we can avoid conversion with a targeted profile.

[tokejepsen]

Looks great. Just one question - if we are adding colorspace information to instances (per AOV in Maya), how do we handle cases where color information is not needed or is not even desired. Like data type AOVs - point positions, normals etc. we don't want any conversions on them, yet if I am not mistaken, they'll inherit colorspace from the context? We don't produce reviewable from them, but thumbnails yes - if the file has data in rgba channels.

With targeted profiles we can avoid transcoding of the render passes. Something like this;

[mkolar]

@tokejepsen please resolve the conflict and we can merge

[tokejepsen]

@tokejepsen please resolve the conflict and we can merge

Shouldnt merge until #4291 is merged.

[tokejepsen]

@mkolar ready to merge.