Maya: OP-2630 acescg maya

openpype/hosts/maya/api/lib.py

@@ -5,6 +5,7 @@
 import platform
 import uuid
 import math
+import re
 
 import json
 import logging
@@ -14,7 +15,7 @@
 from six import string_types
 
 from maya import cmds, mel
-import maya.api.OpenMaya as om
+from maya.api import OpenMaya
 
 from openpype.client import (
  get_project,
@@ -3379,3 +3380,56 @@ def dgcontext(mtime):
 def get_attribute_input(attr):
  connections = cmds.listConnections(attr, plugs=True, destination=False)
  return connections[0] if connections else None
+
+
+def get_color_management_preferences():
+ """Get and resolve OCIO preferences."""
+ data = {
+ # Is color management enabled.
+ "enabled": cmds.colorManagementPrefs(
+ query=True, cmEnabled=True
+ ),
+ "rendering_space": cmds.colorManagementPrefs(
+ query=True, renderingSpaceName=True
+ ),
+ "output_transform": cmds.colorManagementPrefs(
+ query=True, outputTransformName=True
+ ),
+ "output_transform_enabled": cmds.colorManagementPrefs(
+ query=True, outputTransformEnabled=True
+ ),
+ "view_transform": cmds.colorManagementPrefs(
+ query=True, viewTransformName=True
+ )
+ }
+
+ # Split view and display from view_transform. view_transform comes in
+ # format of "{view} ({display})".
+ regex = re.compile(r"^(?P<view>.+) \((?P<display>.+)\)$")
+ match = regex.match(data["view_transform"])
+ data.update({
+ "display": match.group("display"),
+ "view": match.group("view")
+ })
+
+ # Get config absolute path.
+ path = cmds.colorManagementPrefs(
+ query=True, configFilePath=True
+ )
+
+ # The OCIO config supports a custom <MAYA_RESOURCES> token.
+ maya_resources_token = "<MAYA_RESOURCES>"
+ maya_resources_path = OpenMaya.MGlobal.getAbsolutePathToResources()
+ path = path.replace(maya_resources_token, maya_resources_path)
+
+ data["config"] = path
+
+ return data
+
+
+def get_color_management_output_transform():
+ preferences = get_color_management_preferences()
+ colorspace = preferences["rendering_space"]
+ if preferences["output_transform_enabled"]:
+ colorspace = preferences["output_transform"]
+ return colorspace

openpype/hosts/maya/api/lib_renderproducts.py

@@ -127,6 +127,7 @@ class RenderProduct(object):
  """
  productName = attr.ib()
  ext = attr.ib() # extension
+ colorspace = attr.ib() # colorspace
  aov = attr.ib(default=None) # source aov
  driver = attr.ib(default=None) # source driver
  multipart = attr.ib(default=False) # multichannel file
@@ -344,7 +345,6 @@ def match_last(tokens, text):
  separator = file_prefix[matches[0].end(1):matches[1].start(1)]
  return separator
 
-
  def _get_layer_data(self):
  # type: () -> LayerMetadata
  # ______________________________________________
@@ -553,6 +553,9 @@ def _get_aov_render_products(self, aov, cameras=None):
  ]
 
  for ai_driver in ai_drivers:
+ colorspace = self._get_colorspace(
+ ai_driver + ".colorManagement"
+ )
  # todo: check aiAOVDriver.prefix as it could have
  # a custom path prefix set for this driver
 
@@ -590,26 +593,32 @@ def _get_aov_render_products(self, aov, cameras=None):
  global_aov = self._get_attr(aov, "globalAov")
  if global_aov:
  for camera in cameras:
- product = RenderProduct(productName=name,
- ext=ext,
- aov=aov_name,
- driver=ai_driver,
- multipart=multipart,
- camera=camera)
+ product = RenderProduct(
+ productName=name,
+ ext=ext,
+ aov=aov_name,
+ driver=ai_driver,
+ multipart=multipart,
+ camera=camera,
+ colorspace=colorspace
+ )
  products.append(product)
 
  all_light_groups = self._get_attr(aov, "lightGroups")
  if all_light_groups:
  # All light groups is enabled. A single multipart
  # Render Product
  for camera in cameras:
- product = RenderProduct(productName=name + "_lgroups",
- ext=ext,
- aov=aov_name,
- driver=ai_driver,
- # Always multichannel output
- multipart=True,
- camera=camera)
+ product = RenderProduct(
+ productName=name + "_lgroups",
+ ext=ext,
+ aov=aov_name,
+ driver=ai_driver,
+ # Always multichannel output
+ multipart=True,
+ camera=camera,
+ colorspace=colorspace
+ )
  products.append(product)
  else:
  value = self._get_attr(aov, "lightGroupsList")
@@ -625,12 +634,32 @@ def _get_aov_render_products(self, aov, cameras=None):
  aov=aov_name,
  driver=ai_driver,
  ext=ext,
- camera=camera
+ camera=camera,
+ colorspace=colorspace
  )
  products.append(product)
 
  return products
 
+ def _get_colorspace(self, attribute):
+ """Resolve colorspace from Arnold settings."""
+
+ def _view_transform():
+ preferences = lib.get_color_management_preferences()
+ return preferences["view_transform"]
+
+ def _raw():
+ preferences = lib.get_color_management_preferences()
+ return preferences["rendering_space"]
+
+ resolved_values = {
+ "Raw": _raw,
+ "Use View Transform": _view_transform,
+ # Default. Same as Maya Preferences.
+ "Use Output Transform": lib.get_color_management_output_transform
+ }
+ return resolved_values[self._get_attr(attribute)]()
+
  def get_render_products(self):
  """Get all AOVs.
 
@@ -659,11 +688,19 @@ def get_render_products(self):
  ]
 
  default_ext = self._get_attr("defaultRenderGlobals.imfPluginKey")
- beauty_products = [RenderProduct(
- productName="beauty",
- ext=default_ext,
- driver="defaultArnoldDriver",
- camera=camera) for camera in cameras]
+ colorspace = self._get_colorspace(
+ "defaultArnoldDriver.colorManagement"
+ )
+ beauty_products = [
+ RenderProduct(
+ productName="beauty",
+ ext=default_ext,
+ driver="defaultArnoldDriver",
+ camera=camera,
+ colorspace=colorspace
+ ) for camera in cameras
+ ]
+
  # AOVs > Legacy > Maya Render View > Mode
  aovs_enabled = bool(
  self._get_attr("defaultArnoldRenderOptions.aovMode")
@@ -804,9 +841,13 @@ def get_render_products(self):
  if not dont_save_rgb:
  for camera in cameras:
  products.append(
- RenderProduct(productName="",
- ext=default_ext,
- camera=camera))
+ RenderProduct(
+ productName="",
+ ext=default_ext,
+ camera=camera,
+ colorspace=lib.get_color_management_output_transform()
+ )
+ )
 
  # separate alpha file
  separate_alpha = self._get_attr("vraySettings.separateAlpha")
@@ -858,10 +899,13 @@ def get_render_products(self):
 
  aov_name = self._get_vray_aov_name(aov)
  for camera in cameras:
- product = RenderProduct(productName=aov_name,
- ext=default_ext,
- aov=aov,
- camera=camera)
+ product = RenderProduct(
+ productName=aov_name,
+ ext=default_ext,
+ aov=aov,
+ camera=camera,
+ colorspace=lib.get_color_management_output_transform()
+ )
  products.append(product)
 
  return products
@@ -1317,7 +1361,12 @@ def get_render_products(self):
 
  products = []
  for cam in self.get_renderable_cameras():
- product = RenderProduct(productName="beauty", ext=ext, camera=cam)
+ product = RenderProduct(
+ productName="beauty",
+ ext=ext,
+ camera=cam,
+ colorspace=lib.get_color_management_output_transform()
+ )
  products.append(product)
 
  return products

openpype/hosts/maya/api/lib_rendersettings.py

@@ -23,7 +23,8 @@ class RenderSettings(object):
  'vray': 'vraySettings.fileNamePrefix',
  'arnold': 'defaultRenderGlobals.imageFilePrefix',
  'renderman': 'rmanGlobals.imageFileFormat',
- 'redshift': 'defaultRenderGlobals.imageFilePrefix'
+ 'redshift': 'defaultRenderGlobals.imageFilePrefix',
+ 'mayahardware2': 'defaultRenderGlobals.imageFilePrefix'
  }
 
  _image_prefixes = {

openpype/hosts/maya/plugins/publish/collect_render.py

@@ -42,7 +42,6 @@
 import re
 import os
 import platform
-import json
 
 from maya import cmds
 import maya.app.renderSetup.model.renderSetup as renderSetup
@@ -265,7 +264,7 @@ def process(self, context):
  self.log.info(full_exp_files)
  self.log.info("collecting layer: {}".format(layer_name))
  # Get layer specific settings, might be overrides
-
+ colorspace_data = lib.get_color_management_preferences()
  data = {
  "subset": expected_layer_name,
  "attachTo": attach_to,
@@ -318,7 +317,10 @@ def process(self, context):
  "aovSeparator": layer_render_products.layer_data.aov_separator, # noqa: E501
  "renderSetupIncludeLights": render_instance.data.get(
  "renderSetupIncludeLights"
- )
+ ),
+ "colorspaceConfig": colorspace_data["config"],
+ "colorspaceDisplay": colorspace_data["display"],
+ "colorspaceView": colorspace_data["view"]
  }
 
  # Collect Deadline url if Deadline module is enabled

openpype/hosts/maya/startup/userSetup.py

@@ -4,10 +4,10 @@
 from openpype.hosts.maya.api import MayaHost
 from maya import cmds
 
+
 host = MayaHost()
 install_host(host)
 
-
 print("starting OpenPype usersetup")
 
 # build a shelf

openpype/lib/transcoding.py

@@ -1037,3 +1037,63 @@ def convert_ffprobe_fps_to_float(value):
  if divisor == 0.0:
  return 0.0
  return dividend / divisor
+
+
+def convert_colorspace(
+ input_path,
+ output_path,
+ config_path,
+ source_colorspace,
+ target_colorspace,
+ view=None,
+ display=None,
+ logger=None
+):
+ """Convert source file from one color space to another.
+
+ Args:
+ input_path (str): Path that should be converted. It is expected that
+ contains single file or image sequence of same type
+ (sequence in format 'file.FRAMESTART-FRAMEEND#.exr', see oiio docs)
+ output_path (str): Path to output filename.
+ config_path (str): path to OCIO config file
+ source_colorspace (str): ocio valid color space of source files
+ target_colorspace (str): ocio valid target color space
+ if filled, 'view' and 'display' must be empty
+ view (str): name for viewer space (ocio valid)
+ both 'view' and 'display' must be filled (if 'target_colorspace')
+ display (str): name for display-referred reference space (ocio valid)
+ logger (logging.Logger): Logger used for logging.
+ Raises:
+ ValueError: if misconfigured
+ """
+ if logger is None:
+ logger = logging.getLogger(__name__)
+
+ oiio_cmd = [
+ get_oiio_tools_path(),
+ input_path,
+ # Don't add any additional attributes
+ "--nosoftwareattrib",
+ "--colorconfig", config_path
+ ]
+
+ if all([target_colorspace, view, display]):
+ raise ValueError("Colorspace and both screen and display"
+ " cannot be set together."
+ "Choose colorspace or screen and display")
+ if not target_colorspace and not all([view, display]):
+ raise ValueError("Both screen and display must be set.")
+
+ if target_colorspace:
+ oiio_cmd.extend(["--colorconvert",
+ source_colorspace,
+ target_colorspace])
+ if view and display:
+ oiio_cmd.extend(["--iscolorspace", source_colorspace])
+ oiio_cmd.extend(["--ociodisplay", display, view])
+
+ oiio_cmd.extend(["-o", output_path])
+
+ logger.debug("Conversion command: {}".format(" ".join(oiio_cmd)))
+ run_subprocess(oiio_cmd, logger=logger)