Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Feature/pype 754 review burnin filtering #103

Merged
merged 76 commits into from
May 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
6326719
initial commit for review and burnin filtering
iLLiCiTiT Apr 21, 2020
6040327
filter_profiles_by_data renamed to find_matching_profile and swaped a…
iLLiCiTiT Apr 22, 2020
06f0312
find_matching_profile has more complex system of getting most matchin…
iLLiCiTiT Apr 22, 2020
f84d9dc
added filter_outputs_by_tags to filter outputs per representation
iLLiCiTiT Apr 22, 2020
a4a1d0b
added first step of representation loop
iLLiCiTiT Apr 22, 2020
bf59ec9
added image/view exts and supported exts
iLLiCiTiT Apr 22, 2020
dfc3249
first step of representations loop
iLLiCiTiT Apr 22, 2020
0586fff
few more steps and added few comments
iLLiCiTiT Apr 22, 2020
9ed201c
process is splitted more than already was
iLLiCiTiT Apr 23, 2020
cc153ac
all except reformatting should work
iLLiCiTiT Apr 23, 2020
ed84cf2
fixed typo
iLLiCiTiT Apr 23, 2020
2e85ef7
added ffrpobe streams getting
iLLiCiTiT Apr 24, 2020
a8a2efa
extract should work now
iLLiCiTiT Apr 24, 2020
b011caa
few final touches
iLLiCiTiT Apr 24, 2020
673e531
added profile_exclusion
iLLiCiTiT Apr 24, 2020
c553732
make sure always is accessible path to one input file
iLLiCiTiT Apr 24, 2020
f267476
input resolution is not taken from instance data but from input source
iLLiCiTiT Apr 24, 2020
fcc664f
use instance resolution for output before using input's resolution
iLLiCiTiT Apr 24, 2020
446b91e
extract review slate match new extract review and count values per ea…
iLLiCiTiT Apr 24, 2020
1c93374
burnin script can handle both new and old ExtractBurnin plugin processes
iLLiCiTiT Apr 28, 2020
74f278d
profile filter values are not prestored to dictionary
iLLiCiTiT Apr 28, 2020
fc694cd
"output_filter" for output definition in presets was renamed to "filter"
iLLiCiTiT Apr 28, 2020
59ce9a5
extract burnin updated to care about new burnin presets with backward…
iLLiCiTiT Apr 28, 2020
fa97e76
added logs to legacy processing methods
iLLiCiTiT Apr 28, 2020
4c7bacd
Fixed few bugs in extract review
iLLiCiTiT Apr 28, 2020
89d0bc7
removed unused StringType
iLLiCiTiT Apr 28, 2020
0c42f3d
few fixes in ExtractBurnin
iLLiCiTiT Apr 28, 2020
5ec1e51
fixed few bugs in extract burnin
iLLiCiTiT Apr 28, 2020
0fb7032
better script data log
iLLiCiTiT Apr 28, 2020
498e9ab
fixed arguments in brunin script
iLLiCiTiT Apr 28, 2020
a5efeb6
fixed codec copy in burnin script
iLLiCiTiT Apr 28, 2020
69d0b8d
added quotation marks where paths are used
iLLiCiTiT Apr 28, 2020
e1e3326
using codec from source since -codec copy can't be used
iLLiCiTiT Apr 28, 2020
4ed64d9
fixed logs in burnin script
iLLiCiTiT Apr 28, 2020
29b2196
better handling of images and sequences
iLLiCiTiT Apr 28, 2020
bd854fc
extract review has better check for sequence input
iLLiCiTiT Apr 28, 2020
7b9f29f
make sure output frames are integers
iLLiCiTiT Apr 28, 2020
54c3374
fix join
iLLiCiTiT Apr 28, 2020
0ec66b3
fix codec usage in extract slate review
iLLiCiTiT Apr 29, 2020
19c436f
ffprobe_streams moved to pype.lib
iLLiCiTiT Apr 29, 2020
c9dd40d
better repre debug log
iLLiCiTiT Apr 29, 2020
623b4ac
added logs to burnin script
iLLiCiTiT Apr 29, 2020
9291fda
removed setting tags to families
iLLiCiTiT Apr 29, 2020
5a01e9a
Merge branch 'develop' into feature/PYPE-754_review_burnin_filtering
mkolar May 12, 2020
0545e0c
Merge branch 'develop' into feature/PYPE-754_review_burnin_filtering
iLLiCiTiT May 13, 2020
df20206
Merge remote-tracking branch 'origin/feature/PYPE-754_review_burnin_f…
mkolar May 13, 2020
9de5f00
wrong variable
mkolar May 13, 2020
b566741
change ftrack review tag from `preview` to `ftrackreview`
mkolar May 13, 2020
fd46b96
Merge branch 'develop' into feature/PYPE-754_review_burnin_filtering
iLLiCiTiT May 14, 2020
91b44a2
attempt to fix with doubled ffmpeg args
iLLiCiTiT May 14, 2020
8ed2b66
only first output of extract burnin keep ftrackreview
iLLiCiTiT May 15, 2020
1e0143a
modified few logs
iLLiCiTiT May 15, 2020
13bf4d9
skipped reformat tag
iLLiCiTiT May 15, 2020
46e3c54
fixed multipartExr check
iLLiCiTiT May 18, 2020
1d27c19
moved multipartExr much earlier
iLLiCiTiT May 18, 2020
4027dbf
override argument added before output file
iLLiCiTiT May 19, 2020
c0b85b7
comments changes
iLLiCiTiT May 19, 2020
152cfbb
few minor fixes
iLLiCiTiT May 20, 2020
351d7cb
hopefully fixed issues with rescaling
iLLiCiTiT May 20, 2020
3d7da50
fix scale in legacy code
iLLiCiTiT May 20, 2020
f4a0157
updated legacy code with latest develop
iLLiCiTiT May 20, 2020
6cc864d
Merge branch 'develop' into feature/PYPE-754_review_burnin_filtering
iLLiCiTiT May 20, 2020
774d5de
also check pixel_aspect in skipping part
iLLiCiTiT May 20, 2020
0a07803
removed doubled process method
iLLiCiTiT May 20, 2020
3a6ab54
changed comment and docstring by comments
iLLiCiTiT May 21, 2020
fe77756
boolean variables are easier to see now by comments
iLLiCiTiT May 21, 2020
179f0e2
update changes from PR `extract review reformat issue #166`
iLLiCiTiT May 21, 2020
5203bb3
add profile from input if is set in extract burnin
iLLiCiTiT May 21, 2020
b5fbf1a
use slate's inputs resolution instead of using resolution from instan…
iLLiCiTiT May 21, 2020
8986839
do not use output arguments from output definition
iLLiCiTiT May 21, 2020
8645ee1
moved -y ffmpeg arg to output args
iLLiCiTiT May 21, 2020
f5e66c8
slate is scaled all the time to same resolution as review has
iLLiCiTiT May 21, 2020
e5477dd
fixed variable in extract review rescaling
iLLiCiTiT May 21, 2020
b925090
extract review slate should be backwards compatible
iLLiCiTiT May 21, 2020
6e27c92
fixed index access of iterable object
iLLiCiTiT May 22, 2020
70b1cd0
don't use host name from pyblish's registered_host but from AVALON_AP…
iLLiCiTiT May 22, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions pype/lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -1327,3 +1327,25 @@ def _collect_last_version_repres(self, asset_entities):
)

return output


def ffprobe_streams(path_to_file):
"""Load streams from entered filepath via ffprobe."""
log.info(
"Getting information about input \"{}\".".format(path_to_file)
)
args = [
get_ffmpeg_tool_path("ffprobe"),
"-v quiet",
"-print_format json",
"-show_format",
"-show_streams",
"\"{}\"".format(path_to_file)
]
command = " ".join(args)
log.debug("FFprobe command: \"{}\"".format(command))
popen = subprocess.Popen(command, shell=True, stdout=subprocess.PIPE)

popen_output = popen.communicate()[0]
log.debug("FFprobe output: {}".format(popen_output))
return json.loads(popen_output)["streams"]
1 change: 1 addition & 0 deletions pype/nuke/lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -1669,6 +1669,7 @@ def generate_mov(self, farm=False):
if any(colorspaces):
# OCIOColorSpace with controled output
dag_node = nuke.createNode("OCIOColorSpace")
self._temp_nodes.append(dag_node)
for c in colorspaces:
test = dag_node["out_colorspace"].setValue(str(c))
if test:
Expand Down
2 changes: 1 addition & 1 deletion pype/plugins/ftrack/publish/integrate_ftrack_instances.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def process(self, instance):
"name": "thumbnail" # Default component name is "main".
}
comp['thumbnail'] = True
elif comp.get('preview') or ("preview" in comp.get('tags', [])):
elif comp.get('ftrackreview') or ("ftrackreview" in comp.get('tags', [])):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (86 > 79 characters)

'''
Ftrack bug requirement:
- Start frame must be 0
Expand Down
Loading