Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TVPaint extractor enhancement #1080

Merged
merged 40 commits into from
Mar 5, 2021
Merged

TVPaint extractor enhancement #1080

merged 40 commits into from
Mar 5, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Mar 3, 2021 •
edited
Loading

Changes

  • TVPaint extractor has 2 ways how to extract output
    • first is using george command tv_savesequence which saves all visible layers used for review family
    • second is rendering each frame of each layer from instance individually and if there is more than 1 layer they are composite using PILLOW
      • this way keeps alpha channel
  • output type of extractor is always PNG except thumbnail which is always JPG
  • all instances always collect all layers related to them no matter if they are visible or not
    • instances without any visible layer are automatically turned off for publishing
  • added validator which checks if there is at least one visible layer in the instance
  • rendering range is defined with Mark In and Mark Out
    • all instances have same range
🏴 this depends on
avalon-core ynput/avalon-core#292
🏴 Pype 3.x PR
pype #1084
avalon-core ynput/avalon-core#293

@iLLiCiTiT
removed modifiable save modes from extractor
9271101
@iLLiCiTiT
imlpemented method for copying same temp image files
f85edd3
@iLLiCiTiT
implemented method that will fill frames by pre behavior of a layer
bed900f
@iLLiCiTiT
implemented method that will fill frames by post behavior of a layer
72a6e1d
@iLLiCiTiT
implemented logic of layers compositing using Pillow
5ece25b
@iLLiCiTiT
frame start/end are defined by mark in/out of published clip
796e722
@iLLiCiTiT
collect both layer's position and all layer ids
9b78deb
@iLLiCiTiT
skip savemode filling
df1435e
@iLLiCiTiT
removed previous logic of rendering
cf6d649
@iLLiCiTiT
collect behavior of layer ids to process
cc9369e
@iLLiCiTiT
implemented method that will render and fill all frames of given layer
838ebbe
@iLLiCiTiT
layers are rendered one by one and stored by their position (order)
df4e281
@iLLiCiTiT
rendered frames are composite to final output
d14e584
@iLLiCiTiT
added cleanup method that will remove temp image files of individial …
d8033fc 
…layers
@iLLiCiTiT
pass different arguments and expect different output of render method
f57ecfa
@iLLiCiTiT
keep frame start/end as they are
b8c57e0
@iLLiCiTiT
added some extra logs
c452dc9
@iLLiCiTiT
fixed case when all layers miss image for frame
043a9d9
@iLLiCiTiT
moved composite_images to pype's tvpaint.lib
84f3801
@iLLiCiTiT
using multiprocessing to speed up compositing part
3193ade
@iLLiCiTiT
simplified extractor with tv_savesequence command
554e0f5
@iLLiCiTiT
removed unused lib
bda4296
@iLLiCiTiT iLLiCiTiT mentioned this pull request Mar 3, 2021
Merged
@iLLiCiTiT iLLiCiTiT changed the base branch from 2.x/main to 2.x/develop March 3, 2021 12:47
This was referenced Mar 3, 2021
Merged
Merged
@iLLiCiTiT iLLiCiTiT self-assigned this Mar 3, 2021
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Mar 3, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team March 3, 2021 13:43
@iLLiCiTiT
fix frame range of pass output
e3b686e
@iLLiCiTiT
renamed extract sequence to extract review sequence
86ccfb6
@iLLiCiTiT
moved back tvpaint's lib for compositing
7cb7a5b
@iLLiCiTiT
implemented extract review that can render layer by layer with alpha
253fba6
@iLLiCiTiT
modified extract sequence to skip compositing is rendering only one l…
285d91d 
…ayer
@iLLiCiTiT
removed thumbnail filename variable
8714245
@iLLiCiTiT
merged extractors to one extractor
8004d3c
@iLLiCiTiT
extract sequence use key word arguments in filename template
445b6b5
@iLLiCiTiT
handle "none" behavior
aae0522
@iLLiCiTiT
add files to layer_files_by_frame on creation
7c696a0
@iLLiCiTiT
added some debug loggins messages
075080b
@iLLiCiTiT
review instance stores copy of layers data
97446f6
@iLLiCiTiT
added validation of layers visibility
d69f700
@iLLiCiTiT
do not skip not visible layers for render layer
b1cda0b
@iLLiCiTiT
turn of publishing based on visibility of layers
d7992f1
@iLLiCiTiT
extraction is a little bit faster
50a59f2
@mkolar mkolar merged commit 8708040 into 2.x/develop Mar 5, 2021
@mkolar mkolar added this to the 2.15.4 milestone Mar 5, 2021
@mkolar mkolar deleted the feature/tvpaint_full_extractor branch March 12, 2021 16:04
@mkolar mkolar modified the milestones: 2.15.4, 2.16.0 Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @mkolar