Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: write node colorspace ignore default() label #1199

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

jakubjezek001
Copy link
Member

  • collecting write node was getting colorspace knob with default() string and was causing later errors in review extracting

@jakubjezek001 jakubjezek001 self-assigned this Mar 26, 2021
@jakubjezek001 jakubjezek001 added sponsored Client endorsed or requested host: Nuke hotfix labels Mar 26, 2021
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'


# remove default part of the string
if "default (" in colorspace:
colorspace = re.sub(r"default.\(|\)", "", colorspace)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With such a specific string to replace you can just colorspace.replace("default (", ""). If it doesnt find it, it wont replace it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you are right except there is also the closing bracket to remove but only in case of default ( in name. But yeah it could be written differently.

@mkolar mkolar changed the base branch from 2.x/main to 2.x/develop March 31, 2021 07:25
@mkolar mkolar added this to the 2.16.1 milestone Mar 31, 2021
@mkolar mkolar merged commit d24329c into 2.x/develop Mar 31, 2021
@mkolar mkolar deleted the 2.x/hotfix/nuke-deadline-review-mov branch April 5, 2021 21:29
@mkolar mkolar added the type: bug Something isn't working label Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Nuke sponsored Client endorsed or requested type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants