Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TVPaint asset name validation #1319

Merged
merged 8 commits into from
Apr 19, 2021

Conversation

iLLiCiTiT
Copy link
Member

Changes

  • implemented asset name validation on each instance for publishing
    • asset name for publishing is used from collected instance from metadata which are handled only "On Create"
  • workfile context is not used from "current context" (in api.Session) if workfile does not contain metadata
  • changes from older Pype 2 PR that probably was not converted to Pype 3 (collecting of visible instances and group layers)
Pype 2 PRs
pype #1302

@iLLiCiTiT iLLiCiTiT self-assigned this Apr 13, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team April 13, 2021 11:11
@iLLiCiTiT iLLiCiTiT added host: TV Paint type: enhancement Enhancements to existing functionality labels Apr 13, 2021
@iLLiCiTiT iLLiCiTiT marked this pull request as draft April 13, 2021 11:34
@iLLiCiTiT
Copy link
Member Author

Waiting for proper testing and PR #1320 (added TVPaint schemas to project settings)

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Apr 14, 2021

Not sure if validator should be optional? We discussed that we would want be able to publish into multiple assets which won't be possible with this validator.

EDITED: Question is beacuse of settings...

@mkolar
Copy link
Member

mkolar commented Apr 14, 2021

I would make it non-optional by default. They can always change it in the settings.

@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review April 14, 2021 14:09
@mkolar mkolar requested a review from 64qam April 15, 2021 14:01
@mkolar mkolar added this to the 3.0.0-rc1 milestone Apr 15, 2021
@mkolar mkolar merged commit 8f9f884 into develop Apr 19, 2021
@mkolar mkolar deleted the feature/3.0_tvpaint_asset_name_validation branch May 3, 2021 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: TV Paint type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants