Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Resolve: 17 compatibility issues and load image sequences #1422

Merged
merged 7 commits into from
May 5, 2021

Conversation

create-issue-branch[bot]
Copy link

@create-issue-branch create-issue-branch bot commented Apr 28, 2021

closes #1421

But I have found other new bugs on our code appearing after upgrading Resolve to last version at the moment 17.

I should admit that those api changes are realy frightening. There is no mention about this.

  • launchers with non versioned app
  • new Resolve 17 compatibility fixes
  • fixing loading of image sequences

@jakubjezek001 jakubjezek001 requested a review from a team April 28, 2021 08:34
@jakubjezek001 jakubjezek001 self-assigned this Apr 28, 2021
@jakubjezek001 jakubjezek001 added type: bug Something isn't working host: Resolve labels Apr 28, 2021
@jakubjezek001
Copy link
Member

  • Resolve: loader during multiselection is missing one exr option
  • Resolve: not able to load EXRs

# activate resolve from openpype
avalon.install(bmdvr)

file_processing(path)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no newline at end of file



if __name__ == "__main__":
path = "C:/CODE/__openpype_projects/jtest03dev/shots/sq01/mainsq01sh030/publish/plate/plateMain/v006/jt3d_mainsq01sh030_plateMain_v006.0996.exr"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (148 > 79 characters)

@jakubjezek001 jakubjezek001 changed the title Resolve: fix loading clips to timeline Resolve: 17 compatibility issues and load image sequences May 5, 2021
@jakubjezek001 jakubjezek001 marked this pull request as ready for review May 5, 2021 15:21
dirname, file = os.path.split(fpath)
_name, ext = os.path.splitext(file)
print(dirname)
media_pool_items = media_storage.AddItemListToMediaPool(os.path.normpath(dirname))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (90 > 79 characters)

clip_property = media_pool_item.GetClipProperty()
clip_name = clip_property["File Name"]
_clip_property = media_pool_item.GetClipProperty
clip_name = _clip_property("File Name")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local variable 'clip_name' is assigned to but never used

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there was an optimization in V17 you will generally get faster response if you cherry pick the property of interest right away instead of getting all clip properties: clip_property = media_pool_item.GetClipProperty('File name')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have found out that in v17 None is returned if the GetClipProperty is on an audio clip and it was breaking other processes. This way it was more safe and if it is even faster than great.

@jakubjezek001
Copy link
Member

so after @IgorRidanovic recomendation I had managed to fix the image sequence loading back to timeline

Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mkolar mkolar merged commit a8a4da9 into develop May 5, 2021
@mkolar mkolar deleted the bugfix/1421-resolve-fix-loading-clips-to-timeline branch May 5, 2021 21:09
@mkolar mkolar added this to the 3.0.0 milestone May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Resolve type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve: fix loading clips to timeline
3 participants