Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

List can handle new items correctly #1459

Merged
merged 1 commit into from
May 4, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions openpype/settings/entities/list_entity.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ def index(self, item):
)

def append(self, item):
child_obj = self._add_new_item()
child_obj.set_override_state(self._override_state)
child_obj = self.add_new_item(trigger_change=False)
child_obj.set(item)
self.on_change()

Expand Down Expand Up @@ -92,8 +91,7 @@ def remove(self, item):
raise ValueError("ListEntity.remove(x): x not in ListEntity")

def insert(self, idx, item):
child_obj = self._add_new_item(idx)
child_obj.set_override_state(self._override_state)
child_obj = self.add_new_item(idx, trigger_change=False)
child_obj.set(item)
self.on_change()

Expand All @@ -105,10 +103,16 @@ def _add_new_item(self, idx=None):
self.children.insert(idx, child_obj)
return child_obj

def add_new_item(self, idx=None):
def add_new_item(self, idx=None, trigger_change=True):
child_obj = self._add_new_item(idx)
child_obj.set_override_state(self._override_state)
self.on_change()
if self._override_state is OverrideState.STUDIO:
child_obj.add_to_studio_default([])
elif self._override_state is OverrideState.PROJECT:
child_obj.add_to_project_default([])

if trigger_change:
self.on_change()
return child_obj

def swap_items(self, item_1, item_2):
Expand Down