Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Codec determination in extract burnin #1492

Merged
merged 4 commits into from
May 7, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented May 7, 2021

Issue

Determination of input codec in new FFmpeg does not work the same way as in previously used version of FFmpeg.

Changes

  • added few functions using codec specific keys from input data
    • these functions should be modified or added in future based on requirements of each codec
  • these changes should handle current situation with decreased quality of outputs

Notes

  • don't have enough testing input sources to check all possibilities and validate output
    • there is a chance that I broke something which worked with previous code
  • result will probably never be the same as adding video filters (drawing burnins) to output will aways cause some issues
  • possible solution to keep source 1:1 is to add burnins as part of ExtractReview and force all host implementations to create review with it

@iLLiCiTiT iLLiCiTiT self-assigned this May 7, 2021
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label May 7, 2021
@mkolar mkolar added this to the 3.0.0 milestone May 7, 2021
@mkolar mkolar self-requested a review May 7, 2021 13:16
@mkolar mkolar merged commit de310de into develop May 7, 2021
@mkolar mkolar deleted the bugfix/codec_determination_extract_burnin branch May 7, 2021 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants