Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Hiero: publish audio and add to review #1493

Merged
merged 9 commits into from
May 12, 2021
Merged

Hiero: publish audio and add to review #1493

merged 9 commits into from
May 12, 2021

Conversation

create-issue-branch[bot]
Copy link

@create-issue-branch create-issue-branch bot commented May 7, 2021 •
edited by jakubjezek001
Loading

closes #1378

image
https://miro.com/app/board/o9J_lF8hzT8=/

  • ffmpeg merge/mix all audio clips found in otio audio tracks to one timeline-full-length wav file
  • audio family instances add trimmed wav file as representation
  • review instance add trimmed wav file to data[audio] list of inputs

@jakubjezek001 jakubjezek001 marked this pull request as ready for review May 12, 2021 13:57
@jakubjezek001 jakubjezek001 requested a review from a team May 12, 2021 13:57
@jakubjezek001 jakubjezek001 self-assigned this May 12, 2021
@jakubjezek001 jakubjezek001 added type: enhancement Enhancements to existing functionality host: Hiero labels May 12, 2021
@mkolar mkolar changed the title Hiero: audio to review Hiero: publish audio and add to review May 12, 2021
@mkolar mkolar added this to the 3.0.0 milestone May 12, 2021
mkolar
mkolar approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work really well in my test!

@mkolar mkolar merged commit bdcdc4d into develop May 12, 2021
@mkolar mkolar deleted the feature/1378-hiero-audio-to-review branch May 12, 2021 16:33
@jakubjezek001 jakubjezek001 mentioned this pull request May 13, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar approved these changes

Assignees

@jakubjezek001 jakubjezek001

Labels
host: Hiero type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
3.0.0-rc.5
Development

Successfully merging this pull request may close these issues.

Hiero: audio to review
2 participants
@mkolar @jakubjezek001