Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

OpenPype: use semver module for version resolution #1513

Merged
merged 4 commits into from
May 17, 2021

Conversation

antirotor
Copy link
Member

Feature

This PR is adding semver module and utilizing it for version resolution. OpenPypeVersion is extending semver.VersionInfo. It is adding path and staging attributes to it and slightly changing how staging is working.

3.0.0-rc.1+staging < 3.0.0-rc1
3.0.0+staging < 3.0.0
3.0.0-rc.1+foo-staging < 3.0.0
3.0.0 < 3.0.0 (with path set)
3.0.0 (with zip as path) < 3.0.0 (with dir as path)

This is also adding itself to version list detected during startup, so when we are running newer version then those already installed, current running version will be used.

resolves #1505

@antirotor antirotor added type: enhancement Enhancements to existing functionality backend labels May 14, 2021
@antirotor antirotor requested a review from mkolar May 14, 2021 15:37
@antirotor antirotor self-assigned this May 14, 2021
@antirotor
Copy link
Member Author

This fixes following:

  • If currenly running OpenPype version is higher then the one found installed locally (or in shared folder), current one is used without installing it.
  • When version zip is deleted after it is extracted.
  • Shared versions are now joined by those find locally and highest is selected from these
  • Build time is printed after build.

@mkolar mkolar merged commit 0043f6b into develop May 17, 2021
@mkolar mkolar deleted the feature/version-resolution-in-semver branch May 17, 2021 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Igniter version resolution doesn't consider it's own version
2 participants