Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Default environments per host imlementation #1522

Merged

Conversation

create-issue-branch[bot]
Copy link

@create-issue-branch create-issue-branch bot commented May 18, 2021

Changes

  • each host implementation may have implemented function add_implementation_envs to modify environments before application launch (name of function can be changed...)
  • implementation of the function may return totally different dict or just modify dictionary passed to function
  • all required environments were moved to host implementation except of Resolve and few environment keys
  • some of them are set only if are not set via settings some of them prepend paths in environment key
    • there is currently an issue with blender where is not possible to set BLENDER_USER_SCRIPTS which was not possible even before just mentioning this is not solved
    • harmony has LIB_OPENHARMONY_PATH which is always overriden without validation not sure if it's right
    • houdini has appended & symbol after it's environments not sure if it's requirement?
    • also not sure about few Maya's environments if should be defined in settings or not

closes #1405

@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review May 18, 2021 12:26
@iLLiCiTiT iLLiCiTiT self-assigned this May 18, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team May 18, 2021 12:26
@iLLiCiTiT iLLiCiTiT added type: enhancement Enhancements to existing functionality backend labels May 18, 2021
@mkolar
Copy link
Member

mkolar commented May 18, 2021

houdini has appended & symbol after it's environments not sure if it's requirement?

yes it is. it tells houdini to append it's own environments

harmony has LIB_OPENHARMONY_PATH which is always overriden without validation not sure if it's right

that should be correct yes.

openpype/hosts/maya/__init__.py Outdated Show resolved Hide resolved
@mkolar
Copy link
Member

mkolar commented May 18, 2021

All is looking good. I've tested all hosts apart from TV paint

@mkolar mkolar self-requested a review May 18, 2021 19:04
@mkolar mkolar merged commit b30f0c8 into develop May 18, 2021
@mkolar mkolar deleted the feature/1405-default-environments-per-host-imlementation branch May 18, 2021 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default environments per host imlementation
2 participants