This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
+661
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted methods from existing Delivery Action on FTrack Fixed Delivery Action for sequences
works well. |
mkolar
reviewed
May 20, 2021
Fix for double dot in file name
iLLiCiTiT
reviewed
May 24, 2021
iLLiCiTiT
reviewed
May 24, 2021
iLLiCiTiT
reviewed
May 24, 2021
iLLiCiTiT
reviewed
May 24, 2021
Ideas about dialog:
|
iLLiCiTiT
approved these changes
May 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me
mkolar
suggested changes
May 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I missed it before, but this now doesn't work with sequences at all. I only get one frame.
import clique | ||
import collections | ||
|
||
def collect_frames(files): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expected 2 blank lines, found 1
Fixed, change of logic broke it. Same issue in 2.x though :/. |
mkolar
approved these changes
May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected subsets and their versions could be exported via context menu with a use of predefined Delivery template.
Delivery Action from FTrack was bit refactored, needs to be retested!
Closes https://github.com/pypeclub/client/issues/68
Requires:
ynput/avalon-core#339