Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TVPaint: Publish workfile. #1597

Merged
merged 13 commits into from
May 31, 2021
Merged

TVPaint: Publish workfile. #1597

merged 13 commits into from
May 31, 2021

Conversation

create-issue-branch[bot]
Copy link

@create-issue-branch create-issue-branch bot commented May 27, 2021 •
edited by iLLiCiTiT
Loading

Changes

  • workfile family created automatically in collect instances
  • added vaidator of workfile metadata to make sure published workfile has all required data in
  • fixed usage of "asset" which is not used from workfile metadata but from context

closes #1548

@iLLiCiTiT iLLiCiTiT self-assigned this May 27, 2021
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label May 27, 2021
@iLLiCiTiT iLLiCiTiT requested review from 64qam and mkolar May 27, 2021 12:58
@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review May 27, 2021 13:34
mkolar
mkolar suggested changes May 27, 2021
View reviewed changes
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a separate collector to keep it in line with other hosts and not cram too much into one.

hound[bot]
hound bot reviewed May 31, 2021
View reviewed changes
openpype/hosts/tvpaint/plugins/publish/collect_instances.py
@@ -1,3 +1,4 @@
import os
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'os' imported but unused

@mkolar mkolar self-requested a review May 31, 2021 20:55
@mkolar mkolar merged commit 295468f into develop May 31, 2021
@mkolar mkolar deleted the feature/1548-tvpaint-publish-workfile branch May 31, 2021 22:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hound hound[bot] hound[bot] left review comments

@mkolar mkolar mkolar approved these changes

@64qam 64qam 64qam approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TVPaint: Publish workfile.
3 participants
@mkolar @64qam @iLLiCiTiT