Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Openpype style #1604

Merged
merged 40 commits into from
Jun 1, 2021
Merged

Openpype style #1604

merged 40 commits into from
Jun 1, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented May 28, 2021

Description

Initial PR of OpenPype style. Style was inpired by current settings ui style. Styles are currently used only in Project Manager which didn't have much stylesheets before.

Defined replace syntax inside stylesheet text. Currently works only for colors. It is possible to define colors with using dictionary currently defined in data.json next to stylesheet fiule. Replacement syntax use double colon as key separatior (e.g. {color:bg}.

For some cases is required to do more stepts to take effect style. For example QComboBox must use QStyledItemDelegate as item delegate which is not used by default. QCompleter must use setStyleSheet directly on it popup() view as style is not propagated.

More tools will use it soon. Each of current tools has few custom styles inside using object name or stylesheet inside widget so it is not just replacing their current stylesheets.

image

@iLLiCiTiT iLLiCiTiT self-assigned this May 28, 2021
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label May 28, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team May 28, 2021 11:47
@iLLiCiTiT
Copy link
Member Author

Added Poppins font but it seems that font is vertically offset.

image

@mkolar
Copy link
Member

mkolar commented May 31, 2021

The google font issue should be possible to solve using a character subset to limit it to latin only
https://fonts.googleapis.com/css?family=Poppins&display=swap

There is some discussion on this here as well google/fonts#241

We can download a modified charset for it here https://google-webfonts-helper.herokuapp.com/fonts/poppins?subsets=latin

@mkolar mkolar added this to the 3.0.0 milestone Jun 1, 2021
@mkolar mkolar merged commit f9ded99 into develop Jun 1, 2021
@mkolar mkolar deleted the feature/openpype_style branch June 1, 2021 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants