Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Overscan color extract review #1701

Merged
merged 10 commits into from
Jun 16, 2021
Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jun 14, 2021

Description

Overscan color in extract review is now hardcoded to black (when input vs. output aspect ratio does not match). In some cases it would be nice to have ability to modify it.

Changes

  • ExtractReview has overscan_color attribute which define padding color on aspect ratio change
  • color entity can have defined use_alpha attribute (true/false)
    • color widget won't show alpha inputs is use_alpha is false
  • updated docstring screenshot of Output definitions
  • added Overscan color and Background color to documentation

Screenshot

Input: 4056x2295 | Output: 2048x872

  • Real image: smiley
  • Background color: green
  • Overscan color: red

image

How to test

Option n1

  1. set one output definition of ExtractReview with defined output width and height (e.g. 1920x1080)
  2. prepare image sequence or video file with different aspect ratio (e.g. 400x400)
  • go to step 3

Option n2

  1. set overscan crop to get different aspect ratio (e.g. -10% -0%)
  2. prepare any image sequence or video file
  • go to step 3
  1. set overscan color in the same Output definition to any other color than black too see difference (e.g. red)
  2. put the image sequence of video file in standalone publisher and choose one of families which publish and reate review (e.g. plate, image,...)
  3. make sure PREVIEW in standalone publisher is checked on passed sequence/file
  4. publish -> check output: overscan should have color from step 2

Same should work with different aspect ratios from any host.

Closes: https://github.com/pypeclub/client/issues/105

@iLLiCiTiT iLLiCiTiT self-assigned this Jun 14, 2021
@iLLiCiTiT iLLiCiTiT added sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality labels Jun 14, 2021
@iLLiCiTiT
Copy link
Member Author

Have to add docs for new setting...

@jakubjezek001
Copy link
Member

I am ready to test this but please could you add some testing notes? @iLLiCiTiT

@jakubjezek001 jakubjezek001 removed the request for review from mkolar June 16, 2021 09:06
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great work!

@iLLiCiTiT iLLiCiTiT merged commit 61f2e5a into develop Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sponsored Client endorsed or requested type: documentation type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants