Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Launcher project changes #1733

Merged
merged 5 commits into from
Jun 22, 2021
Merged

Launcher project changes #1733

merged 5 commits into from
Jun 22, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jun 21, 2021

Issue

Project changes may not be propagated in right way. So project clicked on first launcher page may be propagated to project combobox on page 2 but is not propagated to assets widget which is confusing and may cause crash of OpenPype Tray.

This happens since #1725 .

Changes

  • implemented ProjectHandler which handles project changes and refreshing of projects
  • all callbacks related to project changes does not care about anything else that value passed with project change signal
    • ProjectHandler object always make all necessary steps before callbacks are triggered
    • this simplified a lot of code as propagation of project change was sequence based and race coditions were not always right

@iLLiCiTiT iLLiCiTiT added backend type: bug Something isn't working labels Jun 21, 2021
@iLLiCiTiT iLLiCiTiT self-assigned this Jun 21, 2021
@iLLiCiTiT iLLiCiTiT merged commit b8863ff into develop Jun 22, 2021
@mkolar mkolar deleted the bugfix/launcher_project_changes branch August 10, 2021 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants