Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Settings schema without prefill #1753

Merged
merged 19 commits into from
Jun 30, 2021

Conversation

iLLiCiTiT
Copy link
Member

Changes

  • loading of settings schema is handled using SchemaHub
  • schemas are not resolved before are passed to root entity
    • schemas must be resolved in entities that can possibly have 'schema' or 'template' type as children
  • json files that can't be parsed won't cause error if are not used
  • this is required step as now filling of entity children had to be handled in single function which had to know all entities structure but with this change it is entity based so entity and it's schema data can have different definitions of children data (required for this issue)

How to test

It's tricky as everything should work almost the same way.

@iLLiCiTiT iLLiCiTiT self-assigned this Jun 24, 2021
@iLLiCiTiT iLLiCiTiT added backend type: enhancement Enhancements to existing functionality labels Jun 24, 2021
@iLLiCiTiT iLLiCiTiT requested review from 64qam and kalisp June 24, 2021 11:39
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems not to break anything :)

@iLLiCiTiT iLLiCiTiT merged commit e5d30c0 into develop Jun 30, 2021
@mkolar mkolar deleted the feature/settings_schema_wihtout_prefill branch August 10, 2021 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants