Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

FFprobe streams order #1775

Merged
merged 3 commits into from
Jun 29, 2021
Merged

FFprobe streams order #1775

merged 3 commits into from
Jun 29, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jun 29, 2021

Issue

Streams read from input file using ffprobe are not always in order we're using it now. We always expect that first stream is video or image stream but in some cases there can be an audio at first place. That is currently breaking all ffprobe usages.

Changes

  • instead of blindly using first stream from ffprobe is used first most matching the expectations
    • check if stream has width and height
    • ignore audio codec type if we expect video or image
  • modified ffprobe reading in ExtractReview and ExtractReviewSlate
  • ffprobe stdout, stderr is decoded to utf-8 before logging

@iLLiCiTiT iLLiCiTiT self-assigned this Jun 29, 2021
@iLLiCiTiT iLLiCiTiT added backend type: bug Something isn't working labels Jun 29, 2021
@iLLiCiTiT iLLiCiTiT merged commit fc3d8dc into develop Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants