This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Bugfix nuke deadline app name #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\ was recognized in AVALON_APP_NAME as a path separator and normalized for all OS, currently \ is used in this env var as plain separator, cannot be replaced.
\ was recognized in AVALON_APP_NAME as a path separator and normalized for all OS, currently \ is used in this env var as plain separator, cannot be replaced.
kalisp
added
type: bug
|
I would skip whole that part of normalization. It's dangerous on more keys then this. |
|
Yeah, thats probably good idea, but not my call. I don't know that code nor reason, why it was written. So right now I would only duct-tape it and refactor it later. |
mkolar
approved these changes
Aug 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVALON_APP_NAME now contains / as separator between name and version, but existing code normalized it to \.
This skip normalization for key AVALON_APP_NAME