This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Standalone Publisher: Extract harmony zip handle workfile template #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalisp
approved these changes
Sep 6, 2021
mkolar
deleted the
bugfix/extract_harmony_zip_handle_workfile_template
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ExtractHarmonyZipplugin is using"work"template name all the time which has changed with Workfiles: Support more workfile templates #1966Changes
ExtractHarmonyZipusesget_workfile_template_key_from_contextto get right template name