Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

WebserverModule: Removed interface of webserver module #2028

Merged
merged 4 commits into from
Sep 20, 2021
Merged

WebserverModule: Removed interface of webserver module #2028

merged 4 commits into from
Sep 20, 2021

Conversation

iLLiCiTiT
Copy link
Member

Goal

  • not use interface in WebServerModule

Changes

  • removed IWebServerRoutes
  • WebServerModule does not check if modules inherit from IWebServerRoutes but if they have available method webserver_initialization which are called during connect_with_modules

@iLLiCiTiT iLLiCiTiT assigned kalisp, antirotor and iLLiCiTiT and unassigned kalisp and antirotor Sep 15, 2021
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Sep 15, 2021
@iLLiCiTiT iLLiCiTiT mentioned this pull request Sep 15, 2021
Closed
4 tasks
kalisp
kalisp approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, webserver keeps working

@iLLiCiTiT iLLiCiTiT merged commit e308227 into develop Sep 20, 2021
@iLLiCiTiT iLLiCiTiT deleted the feature/webserver_without_interface branch December 13, 2021 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kalisp kalisp kalisp approved these changes

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @kalisp @antirotor