Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Settings for Nuke IncrementScriptVersion #2039

Merged
merged 3 commits into from
Sep 22, 2021

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Sep 17, 2021

Plugin for increasing workfile version is now configurable, optional and families could be selected. (Default setting as per current configuration in the plugin.)

Closes https://app.clickup.com/t/6658547/PYPE-1839

On client side Setting must be set as they request!

Screenshot 2021-09-17 130341

@kalisp kalisp added type: enhancement Enhancements to existing functionality host: Nuke labels Sep 17, 2021
@kalisp kalisp self-assigned this Sep 17, 2021
@mkolar
Copy link
Member

mkolar commented Sep 17, 2021

@kalisp kalisp changed the title Removal of unwanted change Settings for Nuke IncrementScriptVersion Sep 17, 2021
@mkolar
Copy link
Member

mkolar commented Sep 17, 2021

To be honest I'm a bit confused as to why we have that filter. The plugin is supposed to only work on workfiles by definition, so why are we filtering render.local and render.farm?

Wouldn't it be enough to have active and optional triggers here?

Plugin should run only when publishing workfile, configuration of families doesn't make sense.
@jakubjezek001
Copy link
Member

There might be a opinion about this workflow from some productions. Sort of:
What if we don't want to increase version of workfile after 'prerender' publishes? or
We would like to keep versioning as less as possible for our client would like to have version synchronized to their review cycle. In that case prerender publishing (and lot of studios already exchange this for deadline submitter) will be heavily incressing the version of workfile in case we will remove the families filter.

@mkolar
Copy link
Member

mkolar commented Sep 20, 2021

In that case prerender publishing (and lot of studios already exchange this for deadline submitter) will be heavily increasing the version of workfile in case we will remove the families filter.

Fair enough. The question is then if this is good enough. because if I'm sending to the farm (prerender or render), I thought we require publish of the workfiles to prevent accidental changes to it during the rendering. Which in turn would raise the version anyway.

@jakubjezek001
Copy link
Member

Yes, that is right, it is broken anyway as we will need to have workfile in context all the time and in that case the plugin will rise it all the time even prerender and its derivate families will be present..

We have to introduce something more solid, based on blacklisting it on taskType and family manner.

Or what are yours sugestions?

@jakubjezek001
Copy link
Member

jakubjezek001 commented Sep 20, 2021

also another alternative would be to introduce something like snapshots of one version. So this would be always publishing workfile even we would publish geo or camera or gizmo. Only difference would be it would not increse v### but it would add suffix with generated hash something like workfilename_v002_oxw2o.nk.

You might ask, why would we do this? This way we could keep strictly the workflow, versioning tightly synced with reviewing cycle and allow separating workflow per publish.

This is just an idea..

@kalisp
Copy link
Member Author

kalisp commented Sep 20, 2021

(Wrote this before seeing last comment.)

I could rewrite plugin to:

  • if workfile is published AND any of the configured family is published too, version workfile up
  • if workfile is not published (local render, as I am guessing that farm render forces publishing of workfile), do not version up, even if any configured family is being published (eg. I am publishing prerender locally, but I dont want to version up workfile.)

@kalisp
Copy link
Member Author

kalisp commented Sep 20, 2021

Removed 'families' configuration

@jakubjezek001
Copy link
Member

jakubjezek001 commented Sep 21, 2021

also another alternative would be to introduce something like snapshots of one version. So this would be always publishing workfile even we would publish geo or camera or gizmo. Only difference would be it would not increse v### but it would add suffix with generated hash something like workfilename_v002_oxw2o.nk.

You might ask, why would we do this? This way we could keep strictly the workflow, versioning tightly synced with reviewing cycle and allow separating workflow per publish.

This is just an idea..

moved to wider discussion here https://github.com/pypeclub/OpenPype/discussions/2047

@kalisp kalisp merged commit e41f438 into develop Sep 22, 2021
@kalisp kalisp deleted the PYPE-1839_Workfile-Version-Increment-Upon-Publishing branch September 22, 2021 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Nuke type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants