Removed shell flag in subprocess call

openpype/hosts/standalonepublisher/plugins/publish/extract_thumbnail.py

@@ -108,7 +108,7 @@ def process(self, instance):
  # run subprocess
  self.log.debug("Executing: {}".format(" ".join(subprocess_args)))
  openpype.api.run_subprocess(
- subprocess_args, shell=True, logger=self.log
+ subprocess_args, logger=self.log
  )
 
  # remove thumbnail key from origin repre

openpype/hosts/standalonepublisher/plugins/publish/extract_trim_video_audio.py

@@ -84,7 +84,7 @@ def process(self, instance):
  joined_args = " ".join(ffmpeg_args)
  self.log.info(f"Processing: {joined_args}")
  openpype.api.run_subprocess(
- ffmpeg_args, shell=True, logger=self.log
+ ffmpeg_args, logger=self.log
  )
 
  repre = {

openpype/plugins/publish/extract_jpeg_exr.py

@@ -122,13 +122,14 @@ def process(self, instance):
  self.log.debug("{}".format(subprocess_command))
  try: # temporary until oiiotool is supported cross platform
  run_subprocess(
- subprocess_args, shell=True, logger=self.log
+ subprocess_args, logger=self.log
  )
  except RuntimeError as exp:
  if "Compression" in str(exp):
  self.log.debug("Unsupported compression on input files. " +
  "Skipping!!!")
  return
+ self.log.warning("Conversion crashed", exc_info=True)
  raise
 
  if "representations" not in instance.data:

openpype/plugins/publish/extract_review.py

@@ -228,7 +228,7 @@ def main_process(self, instance):
  )
 
  openpype.api.run_subprocess(
- subprocess_args, shell=True, logger=self.log
+ subprocess_args, logger=self.log
  )
 
  # delete files added to fill gaps

openpype/plugins/publish/extract_review_slate.py

@@ -209,7 +209,7 @@ def process(self, instance):
  "Slate Executing: {}".format(" ".join(slate_subprocess_args))
  )
  openpype.api.run_subprocess(
- slate_subprocess_args, shell=True, logger=self.log
+ slate_subprocess_args, logger=self.log
  )
 
  # create ffmpeg concat text file path
@@ -244,7 +244,7 @@ def process(self, instance):
  "Executing concat: {}".format(" ".join(concat_args))
  )
  openpype.api.run_subprocess(
- concat_args, shell=True, logger=self.log
+ concat_args, logger=self.log
  )
 
  self.log.debug("__ repre[tags]: {}".format(repre["tags"]))