Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Remove IdleManager module #2084

Merged
merged 31 commits into from
Sep 30, 2021
Merged

General: Remove IdleManager module #2084

merged 31 commits into from
Sep 30, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Sep 28, 2021 •
edited
Loading

Changes

  • idle manager removed as module and it's logic was moved to TimersManager (only place where is used)
  • modified mouse and keyboard threads to be Qt based and easily killed
    • this can cause few issues on tray close
  • simplified logic of showing message and stopping timers
  • modified message window initialization and handling of "countdown time"

Resolves: #2023

@iLLiCiTiT
created idle threads in timers manager which are Qt based timers and …
d9cbbbd 
…threads
@iLLiCiTiT
modified UI initialization
84d2185
@iLLiCiTiT
refresh_context is private method
15bb991
@iLLiCiTiT
removed unused methods
81d5953
@iLLiCiTiT
close_widget is private method
dec46b3
@iLLiCiTiT
added missing attributes
d60b245
@iLLiCiTiT
modified showEvent method
7785255
@iLLiCiTiT
added countdown and it's timer
abf644a
@iLLiCiTiT
adde on stop btn click callback
995544a
@iLLiCiTiT
adde on continue click callback
c826b10
@iLLiCiTiT
added close button callback
6c61f31
@iLLiCiTiT
added restart btn callback
cddf357
@iLLiCiTiT
added method to update countdown label
4c8ae9d
@iLLiCiTiT
added public method to change timer stopped attribute
bc1ad2b
@iLLiCiTiT
added countdown timer callbacks
6a8a244
@iLLiCiTiT
added more public methods
4ab065c
@iLLiCiTiT
removed 'bool_*' attributes
b3a7cd8
@iLLiCiTiT
create idle manager in timers manager
88709e3
@iLLiCiTiT
changed access to widget user
7d0cc02
@iLLiCiTiT
TImersManager has tray start and trat exit for idle manager
f2b4b52
@iLLiCiTiT
removed unused methods
2cd450f
@iLLiCiTiT
added signal handler callbacks
d9cd2cc
@iLLiCiTiT
do not prepare idle manager if auto stop is disabled
12d0aed
@iLLiCiTiT
removed unused signal
7fcd46c
@iLLiCiTiT
don't use IIdleManager
92db4b0
@iLLiCiTiT
turn off autostop on MacOs
e3e933a
@iLLiCiTiT
also turn of auto stop if full time is less than 1
8b1fa05
@iLLiCiTiT
removed unused import
0e2b8d5
@iLLiCiTiT
removed idle manager module
2a9a8bb
@iLLiCiTiT
moved cleanup to separated method
85c3e0b
@iLLiCiTiT iLLiCiTiT mentioned this pull request Sep 28, 2021
Closed
4 tasks
@iLLiCiTiT iLLiCiTiT self-assigned this Sep 28, 2021
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Sep 28, 2021
@iLLiCiTiT iLLiCiTiT merged commit 0679972 into develop Sep 30, 2021
@iLLiCiTiT iLLiCiTiT deleted the feature/idle_manager_removement branch December 13, 2021 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar approved these changes

@antirotor antirotor Awaiting requested review from antirotor

@kalisp kalisp Awaiting requested review from kalisp

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenPype modules/addons without interfaces
2 participants
@iLLiCiTiT @mkolar