This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: Change mayaAscii family to mayaScene #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: PYPE-1131 Change mayaAscii family to mayaScene |
mkolar
suggested changes
Oct 5, 2021
| @@ -3,14 +3,14 @@ | |||
| import pyblish.api | |||
|
|
|||
|
|
|||
| class CollectMayaAscii(pyblish.api.InstancePlugin): | |||
| class CollectMayaScene(pyblish.api.InstancePlugin): | |||
There was a problem hiding this comment.
This class name is already used for collecting the workfile itself and because of the clash publishing doesn't work. It is, however more of a problem of the other plugin where the name doesn' match the actual plugin python file name, so I reckon let's rename the class in collect_scene.py to CollectWorkfile and rename the same file to match other hosts collect_workfile.py
When that's done we can leave this class as is COllectMayaScene but let's please match the filename too. from collect_mayaascii.py to collect_mayascene.py
There was a problem hiding this comment.
Should it be collect_maya_scene.py?
mkolar
changed the title
mkolar
approved these changes
Oct 6, 2021
mkolar
added
type: feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.