Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Add ExtractBurnin to photoshop review #2124

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

jlorrain
Copy link
Contributor

The goal is to allow the admin/TD to set the "Add burnin" tags for the extracted reviews from photoshop within the project settings.

Modifications

  • add "photoshop" family to the global ExtractBurnin pyblish plugin
  • add tags options for the mov and the jpg image extracted from the Photoshop ExtractReview pyblish plugin

Here is how it looks in the project settings

image

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks OK for me but right now I am unable to test it directly in photoshop. @kalisp could you please have a look?

Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, just one must be aware, that when adding burnin, the result will comply to settings for burnin. (In my testing I was surprised that new review .jpg with burnin had different resolution than before. Just FYI.)

@mkolar mkolar merged commit c3c3924 into ynput:develop Oct 17, 2021
@mkolar mkolar added type: enhancement Enhancements to existing functionality type: feature Larger, user affecting changes and completely new things and removed type: enhancement Enhancements to existing functionality labels Oct 17, 2021
@jlorrain jlorrain deleted the add_photoshop_burnin_option branch November 4, 2021 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Photoshop type: feature Larger, user affecting changes and completely new things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants