Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Deadline Maya rendering pyblish plugin "override output" option #2273

Closed

Conversation

jlorrain
Copy link
Contributor

Add an "override output" option to the maya render selection set

Why

Allow the operator to override the project rendering output path to perform rendering tests.

How

You can now specify an output path within the Override Output field in the extra attributes of the maya rendering selection set
image

This Path will be used to set the "OutputFilePath" and the "OutputDirectory" submission parameters of the deadline Plugin and Job

@victorbartel victorbartel force-pushed the add_deadline_render_output_override branch from 394ed34 to c1e6f41 Compare December 16, 2021 10:20
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the path check it is working great and I'll be happy to merge it.

Comment on lines +182 to +196
if override:
workspace = cmds.workspace(q=True, rootDirectory=True)
cmds.workspace(root, openWorkspace=True)

filename_0 = cmds.renderSettings(
fullPath=True,
gin="#" * int(padding),
lut=True,
layer=renderlayer or lib.get_current_renderlayer())[0]
filename_0 = re.sub('_<RenderPass>', '_beauty',
filename_0, flags=re.IGNORECASE)

if override:
cmds.workspace(workspace, openWorkspace=True)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is problematic, because if directory specified in override doesn't exist, it will fail there and apart of publishing failure, you'll end up with "corrupted" opened scene (it will have wrong project set). Now it could be solved by context manager or at least by validator checking if override location is valid maya project (that it exists). I personally vote for both validator and for context manager here handling failures.

@antirotor antirotor added host: Maya module: Deadline AWS Deadline related features type: enhancement Enhancements to existing functionality labels Jan 4, 2022
@ClementHector ClementHector force-pushed the add_deadline_render_output_override branch from c1e6f41 to 44eb576 Compare February 2, 2022 10:37
@ClementHector ClementHector force-pushed the add_deadline_render_output_override branch from 44eb576 to c22763f Compare February 7, 2022 10:07
@BigRoy
Copy link
Collaborator

BigRoy commented Feb 8, 2022

This should be cross checked with #2390 and #2679 regarding safety of cleanup.

@mkolar
Copy link
Member

mkolar commented Apr 28, 2022

@antirotor could you give this one more look please? Not sure if we can do anything about it on our end. @jlorrain are you guys using this in production right now?

@ClementHector
Copy link
Contributor

@mkolar This is no longer used at ellipsanime, and @jlorrain has gone on to another adventure ;) I think you can close it.

@mkolar
Copy link
Member

mkolar commented Jun 7, 2022

I agree we should close this as its a bit too dangerous and there doesn't seem to be any real demand for this among current users.

@mkolar mkolar closed this Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya module: Deadline AWS Deadline related features type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants