This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Deadline timeout and logging #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalisp
added
type: bug
|
NOTE: We should maybe not use |
|
I was thinking about it and I think it would be better to keep *_TIMEOUT variables low, if possible. |
antirotor
suggested changes
Nov 25, 2021
| std_output = subprocess.check_output(args, | ||
| cwd=os.path.dirname(openpype_app), | ||
| env=env) | ||
| print(">>> Process result {}".format(std_output)) |
There was a problem hiding this comment.
Now I am not sure if format() won't actually take care of it but as I reacall, output from this comand is bytes so it needs to be properly encoded to utf-8?
Suggested change
| print(">>> Process result {}".format(std_output)) | |
| print(">>> Process result {}".format(std_output.decode("utf-8"))) |
There was a problem hiding this comment.
Its getting printed even without this, but the content length is imho limited.
Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>
Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Deadline nodes are located in the cloud and spun up dynamically it sometimes produces issue of OP not connecting to Mongo resulting in weird failures.
Added more logging to GlobalJobPreload for better debugging, added possibility to drive timeout by AVALON_TIMEOUT, added explicit high timeout to GlobalJobPrelod.
How to test it:
This is difficult, only just by introducing connection lag to DB which would be noticeable when DL job is triggered.