This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: configurable model top level validation #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
reviewed
Nov 29, 2021
iLLiCiTiT
reviewed
Nov 29, 2021
| "(Are there objects in the instance?" | ||
| " Or is it parented in another group?)") | ||
| return assemblies | ||
| if len(assemblies) == 0: |
There was a problem hiding this comment.
I think this condition should be first otherwise will never happen.
EDITED: Will happen only if validate top group is disabled. Is that intended?
There was a problem hiding this comment.
I believe so. Even if you don't validate single top group, it should never be 0. That would mean empty publish
iLLiCiTiT
approved these changes
Nov 29, 2021
mkolar
approved these changes
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix
Provide configurable top level group model validation.
Same as hotfix PR #2320