-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
…tType don't exist in Py3+
This resolves an issue where otherwise `lib.imprint` will fail on `self.data` for this Creator plug-in
- Also refactor import maya.cmds as `mc` to `cmds` to match with other code in the OpenPype code base
- This fixes an issue with Maya 2022.0 where the maya web button was not yet renamed - Tested in Maya 2019.3.1, Maya 2020.4 and Maya 2022.1
We are using this in production with Maya 2022 and are squashing anything that comes up as we go. It's hard to tell when we can consider it fully functional but it's come a long way and is now far from "(Testing Only)" so I've removed that in defaults with 3b63abf Would be nice if some others could give this a go to test it out of course. :) |
Should we maybe flip this from Draft to reviewable? We could Do the remaining work in another PR, so prevent getting this stuck for too long. |
I'd like to - but the color space settings issue unfortunately seem relatively problematic since it does raise errors currently. My idea is to just have extra settings in Admin Settings for Maya 2022+ due to the new color management they introduced. And whenever Maya 2022 is set to "use legacy mode" it falls back to the old settings (since it then supports those just fine). Unfortunately don't have the time on short notice to get that fixed. :( |
@antirotor @mkolar I implemented a first draft for the Color Management logic for Maya 2022 as discussed in this issue but I'm not too happy with the bloated code.
It would be great however if you could test this and play with it to check how it feels and whether it makes ANY sense - since I feel like it doesn't. It's good to keep in mind that you'll need to at least save the project settings once otherwise the key |
We've tested this on clients side now, and it technically works as expected. It's now more of a We think this should be merged to unblock Maya 2022 in general and we can continue dealing with th remaining issues, in further PRs |
This PR fixes issues in Maya 2022 that are happening to the update to new Python 3 in Maya.
Avoid
dict_keys
TypeError inlib.imprint
for Create Render CreatorCommit: cb99b0a
Create Render Creator fails in Maya 2022 with Python 3 due to a TypeError in
lib.imprint
.Description
Fixed by forcing the
.keys()
into a list so it's not a Python3dict_keys
object.Refactor types.BooleanType and types.ListType
Commit: d7b6582
Maya 2022 has Python 3 and Python 3 does not have
types.BooleanType
andtypes.ListType
so I've replaced it with straightbool
andlist
. Which happens to also be what respectively thoses variables were set to in Py2 intypes
thus it should be both backwards and forward compatible.Description
This is a very simple fix to just resolve the actual issue that occurred - which is to make it work in Maya 2022/Py3. It's not trying to re-evaluate whether the code could be improved upon altogether and for example these
maya_is_true
methods could be removed.To fix: